chore: Rust 2024 #2012
Draft
chore: Rust 2024 #2012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Daanvdplas
commented
Apr 10, 2025
| @@ -43,8 +43,8 @@ trailing_comma = "Vertical" | |||
| match_block_trailing_comma = false | |||
| blank_lines_upper_bound = 1 | |||
| blank_lines_lower_bound = 0 | |||
| edition = "2021" # changed | |||
| version = "One" | |||
There was a problem hiding this comment.
deprecated for style_edition
Daanvdplas
commented
Apr 10, 2025
| @@ -54,7 +54,7 @@ color = "Auto" | |||
| unstable_features = true # changed | |||
| disable_all_formatting = false | |||
| skip_children = false | |||
| hide_parse_errors = false | |||
There was a problem hiding this comment.
deprecated for show_parse_errors
Daanvdplas
force-pushed
the
daan/chore-rust_2024
branch
from
b1163bf to
5276e9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes partially use-ink/ink-alliance#43
There were a bunch of fmt changes but I'm not sure whether those are desired as there is no CI in place and adds burden to the review, so I left it out.