GNUmakefile: fix build failure without libseinux #8955

oech3 · 2025-10-19T17:24:45Z

Fixes #7996 .

Separated from #8937 ~~because of unknown test failure for Android.~~

github-actions · 2025-10-19T17:48:12Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/invalid-opt (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/runcon/runcon-no-reorder (fails in this run but passes in the 'main' branch)

.github/workflows/ignore-intermittent.txt

github-actions · 2025-10-20T10:30:14Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/runcon/runcon-no-reorder (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

sylvestre · 2025-10-20T10:32:15Z

sorry but i still don't understand why you have to do that ?

oech3 · 2025-10-20T10:44:50Z

Because this project is impossible to build on Linux without libselinux if chcons are included.

oech3 · 2025-10-20T13:59:08Z

Skipping SELINUX_PROGS is same behavior with cargo build --release --features unix.
If missing progs by default is not acceptible, document and small option are needed to avoid build failure by default on many system.

sylvestre · 2025-10-20T21:31:26Z

Sorry but I still don't get why you need to touch the gnu testsuite. I want to run runcon against them

util/build-gnu.sh

github-actions · 2025-10-20T23:54:30Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/rm/rm1 (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/timeout/timeout (fails in this run but passes in the 'main' branch)

github-actions · 2025-10-23T11:25:59Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions · 2025-10-23T17:17:51Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions · 2025-10-28T04:05:13Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

codspeed-hq · 2025-11-08T10:18:50Z

CodSpeed Performance Report

Merging #8955 will not alter performance

_{Comparing oech3:noselinuxprogs (dfa30bc) with main (73d1bce)}

Summary

✅ 123 untouched
⏩ 5 skipped¹

5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

github-actions · 2025-11-08T10:25:19Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)

github-actions · 2025-11-08T14:31:04Z

GNU testsuite comparison:

GNU test failed: tests/id/context. tests/id/context is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/id/no-context. tests/id/no-context is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/mkdir/selinux. tests/mkdir/selinux is passing on 'main'. Maybe you have to rebase?
GNU test failed: tests/runcon/runcon-no-reorder. tests/runcon/runcon-no-reorder is passing on 'main'. Maybe you have to rebase?
Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/chcon/chcon is now being skipped but was previously passing.
Note: The gnu test tests/cp/no-ctx is now being skipped but was previously passing.
Note: The gnu test tests/install/install-C-selinux is now being skipped but was previously passing.
Note: The gnu test tests/install/install-Z-selinux is now being skipped but was previously passing.
Note: The gnu test tests/ls/selinux is now being skipped but was previously passing.
Note: The gnu test tests/misc/selinux is now being skipped but was previously passing.
Note: The gnu test tests/mkdir/restorecon is now being skipped but was previously passing.

oech3 · 2025-11-08T14:36:13Z

coreutils 9.9 will stop building and testing runcon and chcon by default. I changed this PR to backporting the behavior instead of hacking to force-enabling tests by force-building them. We tests them iff SELINUX_ENABLED=1. So

Warning: Changes from 'main': PASS -9 /
    FAIL +1 / ERROR +0 / SKIP +8
Error: PASS count is reduced from
        'main': PASS -9

should be fine. @sylvestre @cakebaker Would you review this?

github-actions · 2025-11-12T00:50:11Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-12T09:18:25Z

GNU testsuite comparison:

GNU test failed: tests/misc/invalid-opt. tests/misc/invalid-opt is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

github-actions · 2025-11-12T14:11:25Z

GNU testsuite comparison:

GNU test failed: tests/misc/invalid-opt. tests/misc/invalid-opt is passing on 'main'. Maybe you have to rebase?
Skip an intermittent issue tests/misc/usage_vs_getopt (fails in this run but passes in the 'main' branch)

github-actions · 2025-11-12T15:53:41Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

.github/workflows/GnuTests.yml

github-actions · 2025-11-12T16:21:35Z

GNU testsuite comparison:

Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

github-actions · 2025-11-13T16:06:01Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

github-actions · 2025-11-14T07:42:44Z

GNU testsuite comparison:

Skip an intermittent issue tests/misc/tee (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

github-actions · 2025-11-14T10:00:30Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

github-actions · 2025-11-14T10:23:19Z

GNU testsuite comparison:

Skip an intermittent issue tests/tail/overlay-headers (fails in this run but passes in the 'main' branch)

oech3 · 2025-11-14T11:17:55Z

I'll split this to 3 PRs more robust.

sylvestre reviewed Oct 20, 2025

View reviewed changes

.github/workflows/ignore-intermittent.txt Outdated Show resolved Hide resolved

oech3 changed the title ~~Omit SELINUX_PROGS on non SELinux env~~ build: Omit SELINUX_PROGS to avoid build failure without SELinux Oct 20, 2025

oech3 force-pushed the noselinuxprogs branch from a206246 to ef41684 Compare October 20, 2025 23:27

oech3 commented Oct 20, 2025

View reviewed changes

util/build-gnu.sh Outdated Show resolved Hide resolved

oech3 requested a review from sylvestre October 20, 2025 23:55

oech3 force-pushed the noselinuxprogs branch from bdb7a54 to a06c9ca Compare October 23, 2025 11:04

This comment was marked as outdated.

Sign in to view

oech3 mentioned this pull request Oct 25, 2025

GNUmakefile: Add a value for cross-build #9015

Merged

oech3 force-pushed the noselinuxprogs branch from cc627d7 to 4526136 Compare October 28, 2025 03:44

oech3 force-pushed the noselinuxprogs branch from 9a39cba to 1d49a75 Compare November 8, 2025 10:01

oech3 changed the title ~~build: Omit SELINUX_PROGS to avoid build failure without SELinux~~ build: Omit SELINUX_PROGS, fix build failure without SELinux Nov 8, 2025

oech3 force-pushed the noselinuxprogs branch from 242906c to e65f778 Compare November 8, 2025 14:11

oech3 added 4 commits November 9, 2025 02:29

Omit SELINUX_PROGS on non SELinux env

0d61635

Test make without libselinux

796c761

Drop runcon from tests_invalid_opt.patch for non-SELinux env

34d3f0c

build-gnu.sh: Force build SELINUX_PROGS for tests

8dd81de

oech3 changed the title ~~build: Omit SELINUX_PROGS, fix build failure without SELinux~~ GNUmakefile: fix build failure without libseinux Nov 12, 2025

oech3 mentioned this pull request Nov 12, 2025

ci: Mark runcon-no-reorder as SELinux required #9234

Merged

oech3 force-pushed the noselinuxprogs branch from 89b6101 to e98eaee Compare November 12, 2025 12:47

resolve conflict

070559d

oech3 force-pushed the noselinuxprogs branch from e98eaee to 070559d Compare November 12, 2025 12:50

oech3 added 2 commits November 12, 2025 21:56

Merge branch 'main' into noselinuxprogs

50fc779

Reduce diff

a231f26

oech3 added 2 commits November 13, 2025 00:21

Remove libselinux from host

e44a76e

Merge branch 'main' into noselinuxprogs

270b52d

oech3 commented Nov 12, 2025

View reviewed changes

.github/workflows/GnuTests.yml Outdated Show resolved Hide resolved

oech3 added 3 commits November 13, 2025 21:13

Drop useless string

857563d

Merge branch 'main' into noselinuxprogs

10f1ca7

Merge branch 'main' into noselinuxprogs

c5582d4

oech3 mentioned this pull request Nov 14, 2025

build-gnu.sh: Freeze SELinux build mode #9270

Merged

CICD.yml: Minimize tests

38e7fbe

oech3 force-pushed the noselinuxprogs branch from 08af088 to 38e7fbe Compare November 14, 2025 09:38

Merge branch 'main' into noselinuxprogs

dfa30bc

oech3 closed this Nov 14, 2025

oech3 deleted the noselinuxprogs branch November 15, 2025 13:05

oech3 mentioned this pull request Nov 15, 2025

Fix build failure without libselinux #9290

Merged

Uh oh!

GNUmakefile: fix build failure without libseinux #8955

GNUmakefile: fix build failure without libseinux #8955

Uh oh!

Conversation

oech3 commented Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 19, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 20, 2025

Uh oh!

sylvestre commented Oct 20, 2025

Uh oh!

oech3 commented Oct 20, 2025

Uh oh!

oech3 commented Oct 20, 2025

Uh oh!

sylvestre commented Oct 20, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 20, 2025

Uh oh!

This comment was marked as outdated.

github-actions bot commented Oct 23, 2025

Uh oh!

github-actions bot commented Oct 23, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

codspeed-hq bot commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging #8955 will not alter performance

Summary

Footnotes

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

github-actions bot commented Nov 8, 2025

Uh oh!

oech3 commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 12, 2025

Uh oh!

github-actions bot commented Nov 12, 2025

Uh oh!

github-actions bot commented Nov 12, 2025

Uh oh!

github-actions bot commented Nov 12, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 12, 2025

Uh oh!

github-actions bot commented Nov 13, 2025

Uh oh!

github-actions bot commented Nov 14, 2025

Uh oh!

github-actions bot commented Nov 14, 2025

Uh oh!

github-actions bot commented Nov 14, 2025

Uh oh!

oech3 commented Nov 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

oech3 commented Oct 19, 2025 •

edited

Loading

codspeed-hq bot commented Nov 8, 2025 •

edited

Loading

oech3 commented Nov 8, 2025 •

edited

Loading