Skip to content

Conversation

@naoNao89
Copy link
Contributor

@naoNao89 naoNao89 commented Nov 12, 2025

Consolidates the benchmark framework across the entire codebase by migrating factor benchmarks from Criterion to Divan.

Closes #1749

@codspeed-hq
Copy link

codspeed-hq bot commented Nov 12, 2025

CodSpeed Performance Report

Merging #9247 will not alter performance

Comparing naoNao89:fix/criterion-html-reports (9193076) with main (d432131)

Summary

✅ 123 untouched
⏩ 5 skipped1

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sylvestre
Copy link
Contributor

Can we port it to divan instead? :)

@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/overlay-headers (passes in this run but fails in the 'main' branch)

@naoNao89 naoNao89 changed the title benchmarks: Suppress Criterion html_reports warning in factor benches: Migrate factor benchmarks from Criterion to Divan Nov 12, 2025
@naoNao89 naoNao89 force-pushed the fix/criterion-html-reports branch 2 times, most recently from b1f6a70 to 4613523 Compare November 12, 2025 23:05
Replace Criterion with Divan to align with all other benchmarks in the
codebase (22 packages use Divan, only factor used Criterion).

Eliminates the html_reports warning and consolidates on a single
benchmarking framework across the project.
@naoNao89 naoNao89 force-pushed the fix/criterion-html-reports branch from 4613523 to 9193076 Compare November 12, 2025 23:14
@github-actions
Copy link

GNU testsuite comparison:

Skipping an intermittent issue tests/misc/tee (passes in this run but fails in the 'main' branch)

@sylvestre sylvestre merged commit 6580919 into uutils:main Nov 15, 2025
126 checks passed
@naoNao89 naoNao89 deleted the fix/criterion-html-reports branch November 16, 2025 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attribute guidance in docs

2 participants