-
Notifications
You must be signed in to change notification settings - Fork 216
SonarCloud fix: java:S125 Sections of code should not be commented out #10394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
SonarCloud fix: java:S125 Sections of code should not be commented out #10394
Conversation
👋 Hello! Thanks for contributing to our project. You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/10394/checks If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
java/code/src/com/redhat/rhn/frontend/action/channel/manage/AddErrataToChannelAction.java
Outdated
Show resolved
Hide resolved
java/code/src/com/redhat/rhn/frontend/action/user/test/CreateUserActionTest.java
Outdated
Show resolved
Hide resolved
java/code/src/com/redhat/rhn/frontend/servlets/PxtCookieManager.java
Outdated
Show resolved
Hide resolved
4a5ab6f
to
fa3279f
Compare
What does this PR change?
SonarCloud error reduction fix, rule java:S125 Sections of code should not be commented out
Commented-out code distracts the focus from the actual executed code. It creates a noise that increases maintenance code. And because it is never executed, it quickly becomes out of date and invalid.
Commented-out code should be deleted and can be retrieved from source control history if required.
GUI diff
No difference.
Documentation
Test coverage
Links
Issue(s): #9878
Port(s): not backported
Changelogs
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: