-
Notifications
You must be signed in to change notification settings - Fork 216
Update UI product migration page #10432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Hello! Thanks for contributing to our project. You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/10432/checks If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @bisht-richa. The code looks good to me, I just commented a couple of nitpicks below.
<c:set var="dryRunTooltip"> | ||
<bean:message key="spmigration.jsp.dryrun.disabled.tooltip" /> | ||
</c:set> | ||
<div class="pull-right test"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the class test
intentional?
<c:if test="${!requestScope.completed}"> | ||
<c:choose> | ||
<c:when test="${hasDryRunCapability}"> | ||
<html:submit styleClass="btn btn-default" property="dispatch"> | ||
<bean:message key="spmigration.jsp.confirm.submit.dry-run" /> | ||
</html:submit> | ||
</c:when> | ||
<c:otherwise> | ||
<html:submit styleClass="btn btn-default" property="dispatch" disabled="true" | ||
title="${dryRunTooltip}"> | ||
<bean:message key="spmigration.jsp.confirm.submit.dry-run" /> | ||
</html:submit> | ||
</c:otherwise> | ||
</c:choose> | ||
</c:if> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentations of some tags don't match in this block. I know it's already messy in the existing code (IDEs usually get confused because of this), but it is still nice to have consistent indentations in the new code.
What does this PR change?
GUI diff
No difference.
Before:
After:

Documentation
No documentation needed: add explanation. This can't be used if there is a GUI diff
DONE
Test coverage
ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite
No tests: add explanation
DONE
Links
Fixes: https://github.com/SUSE/spacewalk/issues/25566
Fixes: https://github.com/SUSE/spacewalk/issues/25143
Port(s): # add downstream PR(s), if any
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:
Before you merge
Check How to branch and merge properly!