Skip to content

Implemented Bootstrap tooltips #10458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Implemented Bootstrap tooltips #10458

wants to merge 9 commits into from

Conversation

bisht-richa
Copy link
Contributor

What does this PR change?

Tooltips have been upgraded to Bootstrap tooltips for a cleaner and more consistent user experience.

GUI diff

Screenshot 2025-06-12 at 13 48 02 Screenshot 2025-06-12 at 13 48 10 Screenshot 2025-06-12 at 13 48 26 Screenshot 2025-06-12 at 13 48 34 Screenshot 2025-06-12 at 13 52 12
  • DONE

Documentation

  • No documentation needed: add explanation. This can't be used if there is a GUI diff

  • DONE

Test coverage

ℹ️ If a major new functionality is added, it is strongly recommended that tests for the new functionality are added to the Cucumber test suite

  • No tests: add explanation

  • DONE

Links

Issue(s): #
Port(s): # add downstream PR(s), if any

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

@bisht-richa bisht-richa marked this pull request as ready for review June 12, 2025 12:54
@bisht-richa bisht-richa requested review from a team as code owners June 12, 2025 12:54
@bisht-richa bisht-richa requested review from CDellaGiusta and removed request for a team June 12, 2025 12:54
Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕

You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/10458/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/10458/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@cbbayburt cbbayburt requested a review from Etheryte June 13, 2025 14:51
cbbayburt
cbbayburt previously approved these changes Jun 13, 2025
Copy link
Contributor

@cbbayburt cbbayburt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java part LGTM 👍

I added @Etheryte as a reviewer for JS

Copy link
Member

@Etheryte Etheryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the comments about global scripts and styles.

@@ -70,6 +71,8 @@ window.spaImportReactPage = function spaImportReactPage(pageName) {
`Found no page with name "${pageName}", did you add the renderer to \`pages\` in \`web/html/src/manager/index.ts\`?`
);
}

initializeTooltips();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is incorrect. Since initializeTooltips creates a MutationObserver, it really only needs to be called once. Right now we create a new MutationObserver on every page navigation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants