Skip to content

Fix Vendor Advisory URL in SUSE Manager directing to error 404 not found (bsc#1243808) #10488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CDellaGiusta
Copy link
Contributor

@CDellaGiusta CDellaGiusta commented Jun 23, 2025

What does this PR change?

Given a SUSE errata advisory (e.g. "SUSE-15-SP6-2025-1733"), both the announcementID (e.g. "SUSE-RU-2025:1733-1") and the advisory url (e.g. "https://www.suse.com/support/update/announcement/2025/suse-ru-202501733-1/") were computed from the errata data, through the class SUSEErrataParser.

The numbering is not anymore following a rule, so the only option to get these data is to download once per day a file from https://ftp.suse.com/pub/projects/security/advisory-map.csv, collect this association data in a table and get the data from there

GUI diff

After:

1
2
3

  • DONE

Documentation

Test coverage

  • Unit tests were added
  • DONE

Links

Issue(s): # https://github.com/SUSE/spacewalk/issues/27375
Port(s): https://github.com/SUSE/spacewalk/pull/27625, https://github.com/SUSE/spacewalk/pull/27622

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

Copy link
Contributor

👋 Hello! Thanks for contributing to our project.
Acceptance tests will take some time (aprox. 1h), please be patient ☕

You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/10488/checks
Once tests finish, if they fail, you can check 👀 the cucumber report. See the link at the output of the action.
You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/10488/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking!
⚠️ You should not merge if acceptance tests fail to pass. ⚠️

@CDellaGiusta CDellaGiusta requested review from a team, rjpmestre, mcalmer and mackdk and removed request for parlt91, a team and rjpmestre June 23, 2025 08:42
Comment on lines 188 to 189
List<ErrataAdvisoryMap> advisoryMapList = downloadErrataAdvisoryMap();
populateErrataAdvisoryMap(advisoryMapList);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe process the file in fixed sized batches instead of loading all the lines into memory? Moreover, it's not very clear to me: is this file going to grow forever or are they going to remove entries from it in the future? If it's the latter, do we need to worry about the links disappearing after an update?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point: now I restructured the parsing so that doesn't load all the stuff in memory.
About the file and its handling: more info as I get it.

@CDellaGiusta CDellaGiusta requested a review from mackdk June 23, 2025 13:28
@CDellaGiusta CDellaGiusta removed the request for review from mackdk June 24, 2025 13:19
@CDellaGiusta CDellaGiusta force-pushed the uyuni-fix-1243808-suse-advisory-url branch from d5a15d4 to fdd451e Compare June 25, 2025 06:54
@CDellaGiusta CDellaGiusta requested a review from a team as a code owner June 25, 2025 14:55
@CDellaGiusta CDellaGiusta requested review from meaksh and removed request for a team June 25, 2025 14:55
@CDellaGiusta CDellaGiusta force-pushed the uyuni-fix-1243808-suse-advisory-url branch from 039d154 to aa342b3 Compare June 25, 2025 17:38
mcalmer
mcalmer previously approved these changes Jun 26, 2025
Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor nitpick

@CDellaGiusta
Copy link
Contributor Author

Only a minor nitpick
leftover. Changed

mackdk
mackdk previously approved these changes Jun 26, 2025
@CDellaGiusta CDellaGiusta force-pushed the uyuni-fix-1243808-suse-advisory-url branch from 0b0835d to e31802b Compare June 26, 2025 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants