-
Notifications
You must be signed in to change notification settings - Fork 216
Fix Vendor Advisory URL in SUSE Manager directing to error 404 not found (bsc#1243808) #10488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix Vendor Advisory URL in SUSE Manager directing to error 404 not found (bsc#1243808) #10488
Conversation
👋 Hello! Thanks for contributing to our project. You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/10488/checks If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
java/code/src/com/suse/manager/errata/advisorymap/ErrataAdvisoryMapFactory.java
Outdated
Show resolved
Hide resolved
java/code/src/com/redhat/rhn/taskomatic/task/ErrataAdvisoryMapSync.java
Outdated
Show resolved
Hide resolved
java/code/src/com/suse/manager/errata/SUSEAdvisoryMapErrataParser.java
Outdated
Show resolved
Hide resolved
java/code/src/com/suse/manager/errata/advisorymap/ErrataAdvisoryMapManager.java
Outdated
Show resolved
Hide resolved
List<ErrataAdvisoryMap> advisoryMapList = downloadErrataAdvisoryMap(); | ||
populateErrataAdvisoryMap(advisoryMapList); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we maybe process the file in fixed sized batches instead of loading all the lines into memory? Moreover, it's not very clear to me: is this file going to grow forever or are they going to remove entries from it in the future? If it's the latter, do we need to worry about the links disappearing after an update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point: now I restructured the parsing so that doesn't load all the stuff in memory.
About the file and its handling: more info as I get it.
java/code/src/com/suse/manager/errata/advisorymap/ErrataAdvisoryMap.java
Outdated
Show resolved
Hide resolved
java/code/src/com/suse/manager/errata/advisorymap/ErrataAdvisoryMapFactory.java
Outdated
Show resolved
Hide resolved
java/code/src/com/suse/manager/errata/advisorymap/ErrataAdvisoryMapManager.java
Outdated
Show resolved
Hide resolved
java/code/src/com/suse/manager/errata/advisorymap/ErrataAdvisoryMapManager.java
Outdated
Show resolved
Hide resolved
schema/spacewalk/susemanager-schema.changes.carlo.uyuni-fix-1243808-suse-advisory-url
Outdated
Show resolved
Hide resolved
java/spacewalk-java.changes.carlo.uyuni-fix-1243808-suse-advisory-url
Outdated
Show resolved
Hide resolved
d5a15d4
to
fdd451e
Compare
039d154
to
aa342b3
Compare
aa342b3
to
107037e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a minor nitpick
java/code/src/com/suse/manager/errata/advisorymap/ErrataAdvisoryMapManager.java
Outdated
Show resolved
Hide resolved
|
java/code/src/com/suse/manager/errata/SUSEAdvisoryMapErrataParser.java
Outdated
Show resolved
Hide resolved
java/code/src/com/suse/manager/errata/SUSEAdvisoryMapErrataParser.java
Outdated
Show resolved
Hide resolved
0b0835d
to
e31802b
Compare
What does this PR change?
Given a SUSE errata advisory (e.g. "SUSE-15-SP6-2025-1733"), both the announcementID (e.g. "SUSE-RU-2025:1733-1") and the advisory url (e.g. "https://www.suse.com/support/update/announcement/2025/suse-ru-202501733-1/") were computed from the errata data, through the class SUSEErrataParser.
The numbering is not anymore following a rule, so the only option to get these data is to download once per day a file from https://ftp.suse.com/pub/projects/security/advisory-map.csv, collect this association data in a table and get the data from there
GUI diff
After:
Documentation
Test coverage
Links
Issue(s): # https://github.com/SUSE/spacewalk/issues/27375
Port(s): https://github.com/SUSE/spacewalk/pull/27625, https://github.com/SUSE/spacewalk/pull/27622
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: