-
Notifications
You must be signed in to change notification settings - Fork 216
SonarCloud error reduction fix, miscellaneous 11 rules #10512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
SonarCloud error reduction fix, miscellaneous 11 rules #10512
Conversation
…ave the same condition
…ted only for toString or compareTo calls
…cessed via derived types
…ot be declared public
👋 Hello! Thanks for contributing to our project. You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/10512/checks If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code. Reference tests: KNOWN ISSUES Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience. For more tips on troubleshooting, see the troubleshooting guide. Happy hacking! |
What does this PR change?
SonarCloud error reduction fix, rules:
java:S1118 Utility classes should not have public constructors
java:S2178 Short-circuit logic should be used in boolean contexts
java:S1862 Related if/else if statements should not have the same condition
java:S1110 Redundant pairs of parentheses should be removed
java:S1158 Primitive wrappers should not be instantiated only for toString or compareTo calls
java:S1163 Exceptions should not be thrown in finally blocks
java:S3252 static base class members should not be accessed via derived types
java:S1201 equals method overrides should accept Object parameters
java:S2130 Parsing should be used to convert Strings to primitives
java:S3416 Loggers should be named for their enclosing classes
java:S1130 Exceptions in throws clauses should not be superfluous
java:S5993 Constructors of an abstract class should not be declared public
GUI diff
No difference.
Documentation
Test coverage
Links
Issue(s): #9878
Port(s):not backported
Changelogs
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: