Skip to content

spacewalk-proxy: remove unnecessary dependencies to Squid #4480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

moio
Copy link
Contributor

@moio moio commented Nov 17, 2021

What does this PR change?

Removes unnecessary dependencies between packages, this is useful for the ongoing containerization effort.

GUI diff

No difference.

  • DONE

Documentation

  • No documentation needed: only internal and user invisible changes

  • DONE

Test coverage

  • No tests: already covered

  • DONE

Links

  • DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

  • No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

  • Re-run test "changelog_test"
  • Re-run test "backend_unittests_pgsql"
  • Re-run test "java_pgsql_tests"
  • Re-run test "schema_migration_test_oracle"
  • Re-run test "schema_migration_test_pgsql"
  • Re-run test "susemanager_unittests"
  • Re-run test "javascript_lint"
  • Re-run test "spacecmd_unittests"

@github-actions github-actions bot added the proxy label Nov 17, 2021
@moio
Copy link
Contributor Author

moio commented Nov 17, 2021

@mcalmer I could not see a good reason to keep the requirement in e337d2d - tried out building a branch of this package from my home project and installation/operation works as expected.

Do you see something I might have missed about it?

@mcalmer
Copy link
Contributor

mcalmer commented Nov 17, 2021

@moio take care, that squid is in our proxy pattern. In case we install the product on a real system, squid is needed to be installed.

@moio
Copy link
Contributor Author

moio commented Nov 17, 2021

@mcalmer it is not, but squid is still pulled in by spacewalk-proxy-management. Is that OK or we want an explicit mention in the pattern?

@mcalmer
Copy link
Contributor

mcalmer commented Nov 17, 2021

@moio Ok, this will work.

@moio moio requested a review from mcalmer November 22, 2021 10:45
Copy link
Contributor

@mcalmer mcalmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you need a changelog. This package is not touched so often and to submit it we need at least 1 changelog entry.

@juliogonzalez
Copy link
Member

@moio yes, a changelog entry is needed.

@moio
Copy link
Contributor Author

moio commented Nov 23, 2021

PR test results (no difference from master at the time of writing): https://ci.suse.de/view/Manager/view/Uyuni-PRs/job/uyuni-prs-ci-tests/894/testReport/

moio added a commit that referenced this pull request Nov 26, 2021
Signed-off-by: Silvio Moioli <[email protected]>
@moio moio force-pushed the decouple_spacewalk_proxy_from_squid branch from e337d2d to a8bbe2c Compare December 10, 2021 17:55
@moio moio added the merge-candidate Meaning it needs to be considered for merging when the master branch is frozen label Dec 10, 2021
@mcalmer mcalmer removed the merge-candidate Meaning it needs to be considered for merging when the master branch is frozen label Dec 14, 2021
@moio moio added the merge-candidate Meaning it needs to be considered for merging when the master branch is frozen label Dec 16, 2021
@moio moio requested a review from mcalmer December 16, 2021 10:49
Signed-off-by: Silvio Moioli <[email protected]>
@moio moio force-pushed the decouple_spacewalk_proxy_from_squid branch from 85d036e to ea8a403 Compare December 16, 2021 10:54
@mcalmer mcalmer merged commit ec3a859 into master Dec 16, 2021
@mcalmer mcalmer deleted the decouple_spacewalk_proxy_from_squid branch December 16, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-candidate Meaning it needs to be considered for merging when the master branch is frozen proxy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants