-
Notifications
You must be signed in to change notification settings - Fork 216
spacewalk-proxy: remove unnecessary dependencies to Squid #4480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@moio take care, that squid is in our proxy pattern. In case we install the product on a real system, squid is needed to be installed. |
@mcalmer it is not, but |
@moio Ok, this will work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you need a changelog. This package is not touched so often and to submit it we need at least 1 changelog entry.
@moio yes, a changelog entry is needed. |
PR test results (no difference from |
Signed-off-by: Silvio Moioli <[email protected]>
e337d2d
to
a8bbe2c
Compare
Signed-off-by: Silvio Moioli <[email protected]>
85d036e
to
ea8a403
Compare
What does this PR change?
Removes unnecessary dependencies between packages, this is useful for the ongoing containerization effort.
GUI diff
No difference.
Documentation
No documentation needed: only internal and user invisible changes
DONE
Test coverage
No tests: already covered
DONE
Links
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: