-
Notifications
You must be signed in to change notification settings - Fork 216
Container-based Proxy #4526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Container-based Proxy #4526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c584a7b
to
2fd3881
Compare
30686c4
to
78212a3
Compare
moio
reviewed
Dec 16, 2021
java/code/src/com/redhat/rhn/frontend/xmlrpc/proxy/ProxyHandler.java
Outdated
Show resolved
Hide resolved
moio
reviewed
Dec 16, 2021
moio
reviewed
Dec 16, 2021
8e15b04
to
349fac9
Compare
0a5ed49
to
5383885
Compare
ffc3326
to
3cec974
Compare
bd91026
to
80b24b9
Compare
9a125b3
to
439e46f
Compare
b3f4763
to
52fa112
Compare
a038bad
to
dd7a362
Compare
Allow running the ssh_keygen without a path parameter to generate keys and get them directly as a result.
Calt the Salt runner to ensure Salt certificates are valid.
In order to help setting up new containerized proxies, add a call loading certificate files and providing the needed parameters and dumping the configuration file.
Building container images for OBS is just copying the container folder in SRPMS. the push-packages-toobs.sh works with the container images without a single change.
23ee1cc
to
efae44b
Compare
ktsamis
approved these changes
Mar 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for me to merge, we talked and it should not cause any more turbulence in the testsuites than we have now. We will see Monday if that's true or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Proxy as a containerized application
Based on the RFC design , this PR contains the implementation of the Proxy as a containerized application.
Containers are designed to be 4:
squid
salt-broker
httpd
and Proxy-specific Python WSGI applicationstftpd
An additional container not planned in the initial RFC, but added to the picture to let bootstrapping client works:
sshd
Everything related to containers can be found under
/containers
path of this project, like the branch this PR is based onGUI diff
No difference.
Before:
After:
Documentation
No documentation needed: add explanation. This can't be used if there is a GUI diff
No documentation needed: only internal and user invisible changes
Documentation issue was created: Link for SUSE Manager contributors, Link for community contributors.
(OPTIONAL) Documentation PR
DONE
Test coverage
No tests: add explanation
No tests: already covered
Unit tests were added
Cucumber tests were added
DONE
Links
Fixes #
Tracks # add downstream PR, if any
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Re-run a test
If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run: