Color property addition #42
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this PR! Do you mind changing the prop name to |
|
The tsconfig being extended doesn't seem to work anymore, or I just couldn't get it to work properly, it's been a while hope it works |
|
Please fix & merge this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it really useful that you created a way to override the current default components for Indicator and Item entirely, but for my usecase I needed something as simple as changing the default color of the selected text.
Why
I just wasn't really vibing with 'blue' because of my terminal configs, and I realized there was no option to override this simple text property as it's currently hard coded.
What it does
My PR just makes it so you can have a color prop in the component to override the default 'blue'.