Fix stuck selection when initialIndex is larger than limit
#44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix 👍 |
vadimdemedes
changed the title
initialIndex is larger than limit
dnnsmnstrr
added a commit
to dnnsmnstrr/ink-select-input
that referenced
this pull request
Mar 4, 2023
* upstream/master: 5.0.0 Migrate to ESM and Ink 4 (vadimdemedes#46) 4.2.2 Refresh dependencies Fix stuck selection when `initialIndex` is larger than `limit` (vadimdemedes#44) 4.2.1 Update peer dependencies to allow React 17.x (vadimdemedes#37) Fix old version link in readme 4.2.0 Reset selected item only when list values change (vadimdemedes#33)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43
selected index would sometimes be greater than the items array length. If initialIndex is ever greater than array length we rotate the array and set the index to the max.
Ran prettier. I appreciate the work on this project.
(I didn't see anything on the contributing.md file on bumping the version so leaving that as is.)