Describe the problem/challenge you have
In the VolumeGroupSnapshot scenario, the VolumeSnapshot doesn't have VolumeSnapshotClass in its spec.
The current data mover backup code will check the VolumeSnapshotClass.
https://github.com/vmware-tanzu/velero/blob/8db1d8943df02138c88501edf97f8d7561690ef9/pkg/backup/actions/csi/pvc_action.go#L474
By far, this field is only used for the internal metadata VolumeInfo to get the CSI driver information for the backed-up volume.
First, it's better we can still have another to figure out the driver information, and we better to not change the DataUpload CRD to achieve that.
Second, if it's hard to do that, we need to make sure the VolumeInfo generation should not crash when the VS doesn't have a VolumeSnapshotClass.
Describe the solution you'd like
Anything else you would like to add:
Environment:
- Velero version (use
velero version):
- Kubernetes version (use
kubectl version):
- Kubernetes installer & version:
- Cloud provider or hardware configuration:
- OS (e.g. from
/etc/os-release):
Vote on this issue!
This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.
- 👍 for "The project would be better with this feature added"
- 👎 for "This feature will not enhance the project in a meaningful way"
Describe the problem/challenge you have
In the VolumeGroupSnapshot scenario, the VolumeSnapshot doesn't have VolumeSnapshotClass in its spec.
The current data mover backup code will check the VolumeSnapshotClass.
https://github.com/vmware-tanzu/velero/blob/8db1d8943df02138c88501edf97f8d7561690ef9/pkg/backup/actions/csi/pvc_action.go#L474
By far, this field is only used for the internal metadata VolumeInfo to get the CSI driver information for the backed-up volume.
First, it's better we can still have another to figure out the driver information, and we better to not change the DataUpload CRD to achieve that.
Second, if it's hard to do that, we need to make sure the VolumeInfo generation should not crash when the VS doesn't have a VolumeSnapshotClass.
Describe the solution you'd like
Anything else you would like to add:
Environment:
velero version):kubectl version):/etc/os-release):Vote on this issue!
This is an invitation to the Velero community to vote on issues, you can see the project's top voted issues listed here.
Use the "reaction smiley face" up to the right of this comment to vote.