Skip to content

[Readme update] Add image registry proxy option to E2E test configuration#9042

Merged
blackpiglet merged 4 commits intovelero-io:mainfrom
priyansh17:readme-update/test
Jun 25, 2025
Merged

[Readme update] Add image registry proxy option to E2E test configuration#9042
blackpiglet merged 4 commits intovelero-io:mainfrom
priyansh17:readme-update/test

Conversation

@priyansh17
Copy link
Copy Markdown
Collaborator

@priyansh17 priyansh17 commented Jun 25, 2025

Signed-off-by: Priyansh Choudhary im1706@gmail.com

This parameter was missing from readme which lets user change the container registry used to pull images. Is necessary when their clusters have policy to block unknown Container registries.

Does your change fix a particular issue?

No

Please indicate you've done the following:

Signed-off-by: Priyansh Choudhary <im1706@gmail.com>
@priyansh17
Copy link
Copy Markdown
Collaborator Author

priyansh17 commented Jun 25, 2025

/kind changelog-not-required

@github-actions github-actions Bot requested review from Lyndon-Li and ywk253100 June 25, 2025 10:01
@github-actions github-actions Bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jun 25, 2025
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>

Signed-off-by: Priyansh Choudhary <im1706@gmail.com>
Comment thread test/e2e/README.md Outdated
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>
@priyansh17 priyansh17 requested a review from anshulahuja98 June 25, 2025 10:14
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.29%. Comparing base (4e5020d) to head (f0f7b08).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9042      +/-   ##
==========================================
- Coverage   60.30%   60.29%   -0.01%     
==========================================
  Files         378      378              
  Lines       42746    42746              
==========================================
- Hits        25777    25774       -3     
- Misses      15419    15421       +2     
- Partials     1550     1551       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blackpiglet blackpiglet merged commit 37a22a3 into velero-io:main Jun 25, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-e2e-2tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants