fix: e2e test case for multiple fs-backup ns mapping#9660
fix: e2e test case for multiple fs-backup ns mapping#9660priyansh17 wants to merge 1 commit intovelero-io:release-1.16from
Conversation
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.16 #9660 +/- ##
================================================
- Coverage 59.84% 59.83% -0.02%
================================================
Files 370 370
Lines 32034 32034
================================================
- Hits 19172 19166 -6
- Misses 11362 11367 +5
- Partials 1500 1501 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
what about other branches? |
|
There was no difference for this case between the release-1.16 and the main branch. I suggest to skip this case in release-1.16 instead of modifying the case logic. |
|
whoops |
|
@priyansh17 |
In Init(), on kind, kibishiiData is intentionally zeroed out (Levels: 0, DirsPerLevel: 0, ...) because kind doesn't support volume snapshots or fs-backup ; volumes aren't backed up (--snapshot-volumes=false without --default-volumes-to-fs-backup). However, CreateResources() and Verify() unconditionally override kibishiiData.Levels to len(*n.NSIncluded) + index, which for the Multiple test sets Levels to 2 and 3. This causes generate.sh to write data into PVCs that never gets backed up, and then verify.sh fails post-restore because the data isn't there.
Fix: Guard the Levels override so it's only applied on non-kind environments where volume data is actually backed up and restored.
Failure logs: https://github.com/vmware-tanzu/velero/actions/runs/23600057117/job/68728032211#logs
Fixes #(issue)
none, e2e test case.
Please indicate you've done the following: