fix: fail backup early when CSI VolumeSnapshot error persists in async poll#9727
Draft
priyansh17 wants to merge 4 commits intovelero-io:mainfrom
Draft
fix: fail backup early when CSI VolumeSnapshot error persists in async poll#9727priyansh17 wants to merge 4 commits intovelero-io:mainfrom
priyansh17 wants to merge 4 commits intovelero-io:mainfrom
Conversation
…CSISnapshotTimeout Signed-off-by: Priyansh Choudhary <im1706@gmail.com>
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>
…ation Signed-off-by: Priyansh Choudhary <im1706@gmail.com>
…r handling in VolumeSnapshot progress Signed-off-by: Priyansh Choudhary <im1706@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9727 +/- ##
==========================================
+ Coverage 60.97% 61.00% +0.02%
==========================================
Files 384 384
Lines 36609 36629 +20
==========================================
+ Hits 22324 22344 +20
Misses 12677 12677
Partials 1608 1608 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please add a summary of your change
pkg/backup/actions/csi/volumesnapshot_action.go, in theProgress()method ofvolumeSnapshotBackupItemAction:progress.Completed=falseeven for permanent errors, so the backup controller keeps polling Progress() for the fullitemOperationTimeout(could be hours), instead of failing immediately.WaitUntilVSCHandleIsReady) properly fails on timeout, but async Progress() does not.The fix is to wait for a certain period of time before failing it/ skipping it.
Does your change fix a particular issue?
Fixes #(issue)
#9674
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.