Open
Conversation
Signed-off-by: emirot <emirot.nolan@gmail.com>
Signed-off-by: emirot <emirot.nolan@gmail.com>
kaovilai
approved these changes
Apr 22, 2026
Contributor
Author
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
blackpiglet
reviewed
Apr 22, 2026
|
|
||
| build-dirs: | ||
| @mkdir -p _output/bin/$(GOOS)/$(GOARCH) | ||
| @mkdir -p .go/src/$(PKG) .go/pkg .go/bin .go/std/$(GOOS)/$(GOARCH) .go/go-build .go/golangci-lint |
Contributor
There was a problem hiding this comment.
Please create the .go/goimports directory here.
@mkdir -p .go/src/$(PKG) .go/pkg .go/bin .go/std/$(GOOS)/$(GOARCH) .go/go-build .go/golangci-lint .go/goimports
blackpiglet
reviewed
Apr 22, 2026
| -v "$$(pwd)/.go/std/$(GOOS)/$(GOARCH):/usr/local/go/pkg/$(GOOS)_$(GOARCH)_static:delegated" \ | ||
| -v "$$(pwd)/.go/go-build:/.cache/go-build:delegated" \ | ||
| -v "$$(pwd)/.go/golangci-lint:/.cache/golangci-lint:delegated" \ | ||
| -v "$$(pwd)/.go/golangci-lint:/.cache/goimports" \ |
Contributor
There was a problem hiding this comment.
Suggest to use the created .go/goimports directory here
Suggested change
| -v "$$(pwd)/.go/golangci-lint:/.cache/goimports" \ | |
| -v "$$(pwd)/.go/goimports:/.cache/goimports:delegated" \ |
blackpiglet
requested changes
Apr 22, 2026
Contributor
blackpiglet
left a comment
blackpiglet
left a comment
There was a problem hiding this comment.
Please check my comments for details.
The current change doesn't look right.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
When doing
make lintlocally I get this issue #9702Does your change fix a particular issue?
Fixes #9702
@kaovilai
After
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.