fix: improve error handling for discarded hooks in WaitExecHookHandler#9750
Open
priyansh17 wants to merge 1 commit intovelero-io:mainfrom
Open
fix: improve error handling for discarded hooks in WaitExecHookHandler#9750priyansh17 wants to merge 1 commit intovelero-io:mainfrom
priyansh17 wants to merge 1 commit intovelero-io:mainfrom
Conversation
Signed-off-by: Priyansh Choudhary <im1706@gmail.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Priyansh Choudhary im1706@gmail.com
Thank you for contributing to Velero!
Please add a summary of your change
The early-return in HandleHooks (when byContainer empty or pod==nil) should Record(... hookFailed=true ...) in the multiHookTracker, or else never Add such hooks in the first place. Otherwise, tracker cannot complete, and the restore gets stuck forever.
Does your change fix a particular issue?
Yes
Fixes #(issue)
#9749
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.