Skip to content

fix: improve error handling for discarded hooks in WaitExecHookHandler#9750

Open
priyansh17 wants to merge 1 commit intovelero-io:mainfrom
priyansh17:priyansh/issue-9749
Open

fix: improve error handling for discarded hooks in WaitExecHookHandler#9750
priyansh17 wants to merge 1 commit intovelero-io:mainfrom
priyansh17:priyansh/issue-9749

Conversation

@priyansh17
Copy link
Copy Markdown
Collaborator

@priyansh17 priyansh17 commented Apr 24, 2026

Signed-off-by: Priyansh Choudhary im1706@gmail.com

Thank you for contributing to Velero!

Please add a summary of your change

The early-return in HandleHooks (when byContainer empty or pod==nil) should Record(... hookFailed=true ...) in the multiHookTracker, or else never Add such hooks in the first place. Otherwise, tracker cannot complete, and the restore gets stuck forever.

Does your change fix a particular issue?

Yes
Fixes #(issue)
#9749

Please indicate you've done the following:

Signed-off-by: Priyansh Choudhary <im1706@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

❌ Patch coverage is 19.04762% with 17 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/hook/wait_exec_hook_handler.go 10.52% 17 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant