Added warning when pages dir is not present #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xists as a sibling of the project root
rauchg
reviewed
Oct 16, 2016
bin/next-dev
Outdated
| if (await exists(join(dir, '..', 'pages'))) { | ||
| console.warn('> Pssst, there is a pages directory next to your project root. Next expects this to be under your project root directory.') | ||
| } else { | ||
| console.warn('> Couldn\'t find a pages directory. Please create one under the project root') |
bin/next-dev
Outdated
| // Check if pages dir exists and warn if not | ||
| if (!await exists(join(dir, 'pages'))) { | ||
| if (await exists(join(dir, '..', 'pages'))) { | ||
| console.warn('> Pssst, there is a pages directory next to your project root. Next expects this to be under your project root directory.') |
Member
There was a problem hiding this comment.
I would say:
> No `pages` directory found. Did you mean to run `next` in the parent (`../`) directory?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added warning when pages dir is not present and a special one if it exists as a sibling of the project root.
Please review the copy :)