docs(examples/with-redux-persist): add 'Open in StackBlitz' button #25972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamVerschueren
requested review from
divmain,
ijjk,
leerob,
lfades,
shuding and
timneutkens
as code owners
|
Awesome work @SamVerschueren 👏 |
|
Updated the PR by adding a button to the |
leerob
approved these changes
Jun 10, 2021
janicklas-ralph
pushed a commit
to janicklas-ralph/next.js
that referenced
this pull request
Jun 11, 2021
…ercel#25972) Add `Open in StackBlitz` button to `examples/with-redux-persist` and `examples/with-videojs`. #### with-redux-persist At first we though the example didn't work correctly in WebContainer because it shows the following message > redux-persist failed to create sync storage. falling back to noop storage. After investigating this, we saw the same message on local as well and is probably intended behaviour because of SSR. The example works, but it makes sense that it can't get the local storage on the server side and that's what causing the message. #### with-videojs The video's couldn't be played in the preview frame before. I fixed it on our end and thus also added the StackBlitz button. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [x] Example(s) updated - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [x] Make sure the linting passes
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Jun 16, 2021
…ercel#25972) Add `Open in StackBlitz` button to `examples/with-redux-persist` and `examples/with-videojs`. #### with-redux-persist At first we though the example didn't work correctly in WebContainer because it shows the following message > redux-persist failed to create sync storage. falling back to noop storage. After investigating this, we saw the same message on local as well and is probably intended behaviour because of SSR. The example works, but it makes sense that it can't get the local storage on the server side and that's what causing the message. #### with-videojs The video's couldn't be played in the preview frame before. I fixed it on our end and thus also added the StackBlitz button. ## Bug - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added ## Feature - [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. - [ ] Related issues linked using `fixes #number` - [ ] Integration tests added - [ ] Documentation added - [x] Example(s) updated - [ ] Telemetry added. In case of a feature if it's used or not. ## Documentation / Examples - [x] Make sure the linting passes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Open in StackBlitzbutton toexamples/with-redux-persistandexamples/with-videojs.with-redux-persist
At first we though the example didn't work correctly in WebContainer because it shows the following message
After investigating this, we saw the same message on local as well and is probably intended behaviour because of SSR. The example works, but it makes sense that it can't get the local storage on the server side and that's what causing the message.
with-videojs
The video's couldn't be played in the preview frame before. I fixed it on our end and thus also added the StackBlitz button.
Bug
fixes #numberFeature
fixes #numberDocumentation / Examples