fix(watch): exit command if persistent task exits #8858
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
requested review from
tknickman and
dimitropoulos
and removed request for
a team
🟢 CI successful 🟢Thanks |
🟢 Turbopack Benchmark CI successful 🟢Thanks |
NicholasLYang
approved these changes
Jul 30, 2024
|
Only note I have is that we could probably create an integration test for this |
chris-olszewski
force-pushed
the
olszewski/fix_watch_exit_on_persitent_exit
branch
from
dd793dd to
275b057
Compare
|
Resurrecting this PR in response to #10122 This never got merged as adding the suggested integration test uncovered a race condition in this PR. Race was that sometimes logs for the exited persistent task would get printed twice. 🙃 |
chris-olszewski
force-pushed
the
olszewski/fix_watch_exit_on_persitent_exit
branch
from
275b057 to
50ac610
Compare
Merged
chris-olszewski
pushed a commit
that referenced
this pull request
Jun 26, 2025
I'm 0% certain that this is a structurally sound change - but it does fix the logs regression in #8858.
I'm 0% certain that this is a structurally sound change - but it does fix the logs regression in #8858.
chris-olszewski
force-pushed
the
olszewski/fix_watch_exit_on_persitent_exit
branch
from
f1b1eb1 to
bc91f53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Now exit if persistent tasks exit. Previously we would not check if persistent tasks exited leading to situations where the
TUIwould shut down, but we still hadwatchrunning.Testing Instructions
Before:
Screen.Recording.2024-07-26.at.4.19.05.PM.mov
Notice that the TUI exits, but
turbodoes not.After:
Screen.Recording.2024-07-26.at.4.15.48.PM.mov