Refactor VerificationService #724
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpoli
force-pushed
the
verify-programs
branch
2 times, most recently
from
b17beaa to
8490d9c
Compare
fpoli
force-pushed
the
verify-programs
branch
from
8490d9c to
c285829
Compare
|
Are the changes to |
|
I didn't update the dependencies. I think we still need #415 in the end. |
|
Silicon doesn't seem to be thread-safe yet: viperproject/silicon#578 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring prepares
VerificationServiceto be asynchronous (in a future PR that makesVerificationService::verifyreturn aFuture, upgrading toreqwest >= 0.10).The Prusti server has been designed to handle concurrent verification requests, but so far we used it sequentially because there were concurrency issues (now fixed) in Viper.
@vakaras I changed the service to take a single program, not a vector. It makes it easier to limit the number of concurrent verification requests.
The diff is negative 🎉