Skip to content

Add Arm64 CI support for Unit tests in Vitess #18343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ranimandepudi
Copy link

This PR adds native Arm64 support to Vitess’s unit test GitHub Actions workflows. The goal is to ensure Vitess tests run cleanly on modern Arm-based environments alongside existing coverage.

Changes made:
• Added matrix.arch: [amd64, arm64] to all unit test workflows
• Dynamic runs-on logic to use the correct GitHub-hosted runner
• Parameterized etcd download using ${ARCH} to ensure correct binary per platform
• Safely skipped MySQL 5.7 workflows on Arm64, since Oracle does not provide .deb packages for Arm
• Updated test/templates/unit_test.tpl to preserve changes with make generate_ci_workflows

Unit test workflows now Arm64 ready are:
unit_test_mysql80.yml
• unit_test_mysql84.yml
• unit_test_evalengine_mysql80.yml
• unit_test_evalengine_mysql84.yml
• unit_race.yml
• unit_race_evalengine.yml
Excluded:
• unit_test_mysql57.yml
• unit_test_evalengine_mysql57.yml

Further Work that is in progress:

  • Add Arm64 support for e2e tests
  • Enable multi-arch docker builds
  • Documentation Updates

Thanks for reviewing this PR and for all your work on Vitess!
This change adds Arm64 support to the unit test CI workflows, enabling testing across both amd64 and arm64 platforms using GitHub Actions.
I’m happy to refine or break this PR into smaller pieces if that helps.

Copy link
Contributor

vitess-bot bot commented Jun 9, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 9, 2025
@ranimandepudi ranimandepudi changed the title Add Arm64 CI support for Unit tests in Citess Add Arm64 CI support for Unit tests in Vitess Jun 9, 2025
@github-actions github-actions bot added this to the v23.0.0 milestone Jun 9, 2025
@deepthi
Copy link
Member

deepthi commented Jun 9, 2025

Looks like DCO is failing.
If the dev env is setup by following the instructions on the website https://vitess.io/docs/contributing/build-on-macos/, the source dev.env step actually sets up the necessary git pre-commit hooks that will prompt you to signoff each commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants