Add Arm64 CI support for Unit tests in Vitess #18343
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds native Arm64 support to Vitess’s unit test GitHub Actions workflows. The goal is to ensure Vitess tests run cleanly on modern Arm-based environments alongside existing coverage.
Changes made:
• Added matrix.arch: [amd64, arm64] to all unit test workflows
• Dynamic runs-on logic to use the correct GitHub-hosted runner
• Parameterized etcd download using ${ARCH} to ensure correct binary per platform
• Safely skipped MySQL 5.7 workflows on Arm64, since Oracle does not provide .deb packages for Arm
• Updated test/templates/unit_test.tpl to preserve changes with make generate_ci_workflows
Unit test workflows now Arm64 ready are:
unit_test_mysql80.yml
• unit_test_mysql84.yml
• unit_test_evalengine_mysql80.yml
• unit_test_evalengine_mysql84.yml
• unit_race.yml
• unit_race_evalengine.yml
Excluded:
• unit_test_mysql57.yml
• unit_test_evalengine_mysql57.yml
Further Work that is in progress:
Thanks for reviewing this PR and for all your work on Vitess!
This change adds Arm64 support to the unit test CI workflows, enabling testing across both amd64 and arm64 platforms using GitHub Actions.
I’m happy to refine or break this PR into smaller pieces if that helps.