[Bug] fix: update metaPods cache to use namespace/name as the key #1015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googs1025
force-pushed
the
fix/cache
branch
7 times, most recently
from
cc02721 to
1169792
Compare
varungup90
reviewed
Apr 28, 2025
pkg/cache/cache_impl.go
Outdated
| func (c *Store) GetPod(podName string) (*v1.Pod, error) { | ||
| metaPod, ok := c.metaPods.Load(podName) | ||
| func (c *Store) GetPod(podName, podNamespace string) (*v1.Pod, error) { | ||
| key := fmt.Sprintf("%s/%s", podNamespace, podName) |
Collaborator
There was a problem hiding this comment.
-
Better to make a util method here.
-
Update error messages as well, for example
fmt.Errorf("pod does not exist in the cache: %s", podName)->fmt.Errorf("key does not exist in the cache: %s", key)
Collaborator
There was a problem hiding this comment.
applies to all methods.
Collaborator
Author
There was a problem hiding this comment.
add GeneratePodKey func in util package
varungup90
reviewed
Apr 28, 2025
pkg/cache/cache_metrics.go
Outdated
| c.metaPods.Range(func(podName string, metaPod *Pod) bool { | ||
| c.metaPods.Range(func(key string, metaPod *Pod) bool { | ||
| // Split the key into namespace and name | ||
| parts := strings.Split(key, "/") |
Collaborator
There was a problem hiding this comment.
you can add a util method here as well to check if key is valid.
Collaborator
Author
There was a problem hiding this comment.
add ParsePodKey func in util package
Collaborator
|
overall LGTM, couple of nits. |
googs1025
force-pushed
the
fix/cache
branch
3 times, most recently
from
ff30126 to
af0984e
Compare
Signed-off-by: googs1025 <[email protected]>
kerthcet
reviewed
Apr 29, 2025
Collaborator
kerthcet
left a comment
kerthcet
left a comment
There was a problem hiding this comment.
also LGTM, I think namespaced Pod name is enough now, in kubernetes, we may sometimes use pid to avoid conflict.
googs1025
changed the title
varungup90
approved these changes
Apr 29, 2025
Yaegaki1Erika
pushed a commit
to Yaegaki1Erika/aibrix
that referenced
this pull request
Jul 23, 2025
…lm-project#1015) Signed-off-by: googs1025 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
[Please provide a clear and concise description of your changes here]
Previously, the metaPods cache used only the
nameas the key, which could lead tokey collisions when Pods with the same name existed in different namespaces.
This pr updates cache to use
namespace/nameas the key, ensuring uniquenessand avoiding potential conflicts. This aligns with Kubernetes' common practice of
using
namespace/nameto uniquely identify resources.Related Issues
Resolves: #1008
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.