Skip to content

Conversation

@varungup90
Copy link
Collaborator

Pull Request Description

[Please provide a clear and concise description of your changes here]

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan
Copy link
Collaborator

Jeffwan commented Apr 30, 2025

Do you mean there's no easy way to manage different platforms linux/amd64,linux/arm64 in Makefile? So the PR is to add the support in Github actions preferred way?

@varungup90
Copy link
Collaborator Author

varungup90 commented Apr 30, 2025

Do you mean there's no easy way to manage different platforms linux/amd64,linux/arm64 in Makefile? So the PR is to add the support in Github actions preferred way?

  • Yes, first I tried to update makefile docker-build-all to support multiple platforms. It worked fine locally but on github action, workflow ran for 2 hrs and still could not complete the build.
image
  • After that I moved to github action, here it worked but time to build and push increased from 6 mins to 16 mins. Reason for time increase is because arm image is built on non-arm github runner. There are tutorials to use different machines for different platforms, I will do that in follow up PR.

  • Should I replicate same behavior for release github action? OR we can only keep multi platform image push for release and delete from docker-push-image workflow (since we do not need multi platform images for each commit)?

@Jeffwan
Copy link
Collaborator

Jeffwan commented Apr 30, 2025

Should I replicate same behavior for release github action? OR we can only keep multi platform image push for release and delete from docker-push-image workflow (since we do not need multi platform images for each commit)?

Yeah, I think arm user they just need a release image and may not need it for every commit, I agree with your proposal . BTW, Instead of using the existing release workflow, can we create a separate job for arm users? Just in case it affect the current release flow (some of the steps are not idempotent)

@varungup90
Copy link
Collaborator Author

Should I replicate same behavior for release github action? OR we can only keep multi platform image push for release and delete from docker-push-image workflow (since we do not need multi platform images for each commit)?

Yeah, I think arm user they just need a release image and may not need it for every commit, I agree with your proposal . BTW, Instead of using the existing release workflow, can we create a separate job for arm users? Just in case it affect the current release flow (some of the steps are not idempotent)

Sure, I will create different release workflow which will just upload arm image. Restore the docker-push-image workflow as-is.

Signed-off-by: Varun Gupta <[email protected]>
@varungup90
Copy link
Collaborator Author

varungup90 commented Apr 30, 2025

@Jeffwan Added a new release build for arm64. I tested the code via docker push image but to test release action it need to be merged first. Once merged I will test it out for previous release tags.

Second, docs build is failing due to git checkout error (not related to PR). Can you rerun it?

@Jeffwan
Copy link
Collaborator

Jeffwan commented May 2, 2025

@varungup90 I just see the message. Let me double check the doc error

@Jeffwan
Copy link
Collaborator

Jeffwan commented May 2, 2025

@varungup90 I restart the doc build and it's working fine.

@varungup90 varungup90 merged commit 0ca6da2 into vllm-project:main May 5, 2025
8 checks passed
@Jeffwan Jeffwan deleted the multi-arch branch May 5, 2025 20:23
Yaegaki1Erika pushed a commit to Yaegaki1Erika/aibrix that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants