[Fix] Fix multiple issues for benchmark implementation #1049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Le Xu <[email protected]>
added 8 commits
May 5, 2025 15:59
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
added 3 commits
May 7, 2025 13:23
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Signed-off-by: Le Xu <[email protected]>
Jeffwan
reviewed
May 7, 2025
| --model \"$TARGET_MODEL\" \ | ||
| --api-key \"$API_KEY\" \ | ||
| --time-scale \"$TIME_SCALE\" \ | ||
| --routing-strategy \"$ROUTING_STRATEGY\" \ |
Collaborator
There was a problem hiding this comment.
if we plan to use benchmark against other framework, this is not needed.
Collaborator
|
Overall looks good to me. @happyandslow can you or du help on this issue so we can test these code in each CI run. #1050 |
Signed-off-by: Le Xu <[email protected]>
Jeffwan
approved these changes
May 8, 2025
Yaegaki1Erika
pushed a commit
to Yaegaki1Erika/aibrix
that referenced
this pull request
Jul 23, 2025
…1049) * move prompt decoration to client dispatch function; remove locks * update multiturn dataset generation by adding shared prefix length * update README for workload output format * move predefined synthetic workload files to autoscaling scenarios * update figure explaination in workload generator README * using shuffling instead of sampling from request finder * Adding stats to workload generation * adding routing strategy knob * bug fix in client.py * print fix in workload generator --------- Signed-off-by: Le Xu <[email protected]> Co-authored-by: Le Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR fixes multiple existing issues with benchmark implementation
Related Issues
Resolves: #1029