Skip to content

Conversation

@DwyaneShi
Copy link
Collaborator

Pull Request Description

This PR includes L1Cache and common facilities such as envs, metrics and utils.

  • L1Cache module: eviction policies (LRU/FIFO/S3FIFO) and L1Cache
  • envs/metrics/utils
  • Unit tests for eviction policies and L1Cache

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@DwyaneShi DwyaneShi requested review from Jeffwan and happyandslow May 7, 2025 16:44
- L1Cache module: eviction policies (LRU/FIFO/S3FIFO) and L1Cache
- envs/metrics/utils
- Unit tests for eviction policies and L1Cache

Signed-off-by: Haiyang Shi <[email protected]>
@DwyaneShi DwyaneShi force-pushed the haiyang/kvcache-l1cache branch from 3c1d865 to 8001a1e Compare May 7, 2025 16:59
AIBRIX_KV_CACHE_OL_TIME_MEASUREMENT_ENABLED: bool = True
AIBRIX_KV_CACHE_OL_BREAKDOWN_MEASUREMENT_ENABLED: bool = True

AIBRIX_KV_CACHE_OL_L1_CACHE_ENABLED: bool = True
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have many envs, let's write down these configurations in the doc.

@Jeffwan
Copy link
Collaborator

Jeffwan commented May 7, 2025

@DwyaneShi feel free to merge it once CI job complete

@Jeffwan Jeffwan merged commit 84dd182 into vllm-project:main May 7, 2025
13 checks passed
Yaegaki1Erika pushed a commit to Yaegaki1Erika/aibrix that referenced this pull request Jul 23, 2025
- L1Cache module: eviction policies (LRU/FIFO/S3FIFO) and L1Cache
- envs/metrics/utils
- Unit tests for eviction policies and L1Cache

Signed-off-by: Haiyang Shi <[email protected]>
Co-authored-by: Haiyang Shi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants