[Feature] AIBrix KVCache L2Cache Part1 #1062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DwyaneShi
force-pushed
the
haiyang/kvcache-l2cache-part1
branch
from
79f0699 to
a8833d0
Compare
- connectors - key builders - marshallers - key builder benchmark Signed-off-by: Haiyang Shi <[email protected]>
DwyaneShi
force-pushed
the
haiyang/kvcache-l2cache-part1
branch
from
a8833d0 to
17a2b7c
Compare
Jeffwan
approved these changes
May 7, 2025
| redis = "^6.0.0" | ||
| fakeredis = "^2.28.1" | ||
| codespell = "2.4.1" | ||
| infinistore = "^0.2.35" |
Collaborator
There was a problem hiding this comment.
does hpkv provide whl in pypi ?
Collaborator
Author
There was a problem hiding this comment.
HPKV is provided in our internal pypi, not available from the public one
| # index to support multi-GPU per RNIC. For example, if we have 8 | ||
| # GPUs and 2 RNICs, then GPU 0 to 3 are mapped to RNIC 0, and GPU | ||
| # 4 to 7 are mapped to RNIC 1. | ||
| factor = num_visible_gpus // len(dev_list) |
Collaborator
There was a problem hiding this comment.
em. we may not explicitly pass device list to engine for TP <= 8 case. we can do some improvements later to intelligently search dev_list if that's not given from user.
| gpu_idx = torch.cuda.current_device() | ||
| rnic_idx = gpu_idx // factor | ||
| dev_name = dev_list[rnic_idx] | ||
|
|
Collaborator
There was a problem hiding this comment.
TODO: add gid search logic and add --hint-gid-index to infinistore.ClientConfig to support VNI mode, this can be done later
Yaegaki1Erika
pushed a commit
to Yaegaki1Erika/aibrix
that referenced
this pull request
Jul 23, 2025
- connectors - key builders - marshallers - key builder benchmark Signed-off-by: Haiyang Shi <[email protected]> Co-authored-by: Haiyang Shi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR includes core modules of L2Cache.
Related Issues
Resolves: #[Insert issue number(s)]
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.