Skip to content

Conversation

@Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Jul 1, 2025

Pull Request Description

[Please provide a clear and concise description of your changes here]

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan Jeffwan merged commit 863dae0 into vllm-project:main Jul 1, 2025
10 checks passed
@Jeffwan Jeffwan deleted the jiaxin/storm-service-standalone branch July 1, 2025 09:54
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Jeffwan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the foundational changes and configurations required to enable the stormservice-controller to be deployed and operated as a standalone component. This enhances the modularity of the system, allowing users to deploy only the specific controllers they need, thereby reducing resource consumption and simplifying management for dedicated StormService environments.

Highlights

  • Standalone Deployment Configuration: New Kustomize configurations (kustomization.yaml and patch.yaml) are introduced under config/standalone/stormservice-controller. These files define the necessary resources and modifications to deploy the stormservice-controller as a standalone component, including its CRDs, RBACs, and manager setup.
  • Controller Feature Flag Integration: The cmd/controllers/main.go file is updated to conditionally register the orchestrationv1alpha1 scheme. This registration now occurs only if the features.StormServiceController flag is enabled, allowing for selective inclusion of the StormService controller's API schema based on feature enablement.
  • Dedicated Controller Execution: The patch.yaml specifically modifies the controller manager's arguments to ensure it runs only the stormservice-controller and disables webhooks. This configuration is crucial for a lightweight, dedicated deployment of the StormService controller, preventing it from managing other resources or requiring webhook functionality.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds configuration to support a standalone deployment of the stormservice-controller. I've identified issues related to resource naming and leader election that could cause conflicts when deploying multiple standalone controllers, and a minor code duplication.

# "wordpress" becomes "alices-wordpress".
# Note that it should also match with the prefix (text before '-') of the namespace
# field above.
namePrefix: aibrix-
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The namePrefix aibrix- is too generic and could lead to resource name collisions if another standalone controller is deployed using a similar Kustomization file. To ensure uniqueness, the prefix should be specific to this controller.

namePrefix: aibrix-stormservice-

- name: manager
args:
- --leader-elect
- --leader-election-id=aibrix-controller-manager
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The leader-election-id must be unique for each controller manager instance to prevent conflicts. The current value aibrix-controller-manager is generic and will cause issues if other standalone controllers are deployed. This ID should be unique for the stormservice controller, aligned with the deployment name.

            - --leader-election-id=aibrix-stormservice-controller-manager

Comment on lines +100 to +102
if features.IsControllerEnabled(features.StormServiceController) {
utilruntime.Must(orchestrationv1alpha1.AddToScheme(scheme))
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The call to orchestrationv1alpha1.AddToScheme(scheme) is present in multiple if blocks. Consider refactoring this to reduce redundancy by registering the scheme once if any of these controllers are enabled.

Yaegaki1Erika pushed a commit to Yaegaki1Erika/aibrix that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant