Skip to content

Conversation

@Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Jul 23, 2025

Pull Request Description

Support arm and multi-arch build

  1. use multi-arch in docker-push-images.yaml.
  2. upgrade docker/setup-buildx-action from v2 to v3
  3. use buildx action for individual build jobs instead of our make command

Note: it takes longer time to build and push both amd64 and arm64 images. this is ok. In our PR workflow, we still use make command. Slow post-submit jobs won't affect development experiences.

Related Issues

Resolves: #1089

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@Jeffwan Jeffwan force-pushed the jiaxin/support-arm-build branch from c025445 to aaaa22a Compare July 23, 2025 21:29
@Jeffwan Jeffwan marked this pull request as draft July 23, 2025 21:30
@Jeffwan Jeffwan force-pushed the jiaxin/support-arm-build branch from aaaa22a to d14a05b Compare July 23, 2025 21:34
@Jeffwan Jeffwan force-pushed the jiaxin/support-arm-build branch from d14a05b to 4e1bc1f Compare July 23, 2025 21:48
@Jeffwan Jeffwan marked this pull request as ready for review July 23, 2025 21:51
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Jul 23, 2025

let me merge it and give it a try

@Jeffwan Jeffwan merged commit b26a55d into vllm-project:main Jul 23, 2025
14 checks passed
@Jeffwan Jeffwan deleted the jiaxin/support-arm-build branch July 23, 2025 21:59
ae86zhizhi pushed a commit to ae86zhizhi/aibrix that referenced this pull request Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support ARM64 (aarch64) Architecture for AIBrix Core Components for Deploy k8s arm arch

2 participants