Skip to content

Conversation

@Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Jul 24, 2025

Pull Request Description

[Please provide a clear and concise description of your changes here]

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Jeffwan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new set of examples demonstrating how to deploy SGLang with Prefill/Decode (P/D) disaggregation on Kubernetes, leveraging AIBrix's StormService. These examples showcase different deployment patterns, including pool mode, replica mode, and configurations for tensor parallelism, providing a comprehensive guide for setting up high-performance LLM inference.

Highlights

  • New SGLang Disaggregation Examples: I've added a new directory (samples/disaggregation/sglang) containing detailed Kubernetes YAML configurations for SGLang Prefill/Decode (P/D) disaggregation.
  • Comprehensive Documentation: A README.md is included to guide users through building necessary Docker images (SGLang with Nixl, SGLang Router), configuring Kubernetes RBAC, and running example queries against the disaggregated setup.
  • Diverse Deployment Patterns: Three distinct StormService examples are provided: pool.yaml for a pooled disaggregation setup, replica.yaml for a replica-based disaggregation with a standalone router, and tp-1p1d.yaml showcasing advanced disaggregation with tensor parallelism across multiple nodes for both prefill and decode stages.
  • High-Performance Configuration: All examples are configured for high-performance LLM inference, utilizing nixl as the disaggregation transfer backend, specifying RDMA network annotations, and allocating GPU resources.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several examples for SGLang P/D disaggregation. The examples are well-structured and cover different modes like pool, replica, and tensor parallelism. I've identified areas for improvement concerning portability and robustness, including hardcoded values in Kubernetes manifests and the use of hostPath volumes. Addressing these points will make the examples more robust, secure, and easier to use.

@Jeffwan Jeffwan force-pushed the jiaxin/sglang-disaggregation-example branch 4 times, most recently from 9972139 to 2938d9f Compare July 24, 2025 21:34
@Xunzhuo
Copy link
Member

Xunzhuo commented Jul 25, 2025

@Jeffwan this is going to use mini_lb instead of the gateway to do p/d disaggregation?

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Jul 25, 2025

@Xunzhuo No, this is not the ideal state—it's just the initial phase. Once the router capability is ready, we can switch over to using the router.

@Jeffwan Jeffwan force-pushed the jiaxin/sglang-disaggregation-example branch from 2938d9f to 5301caf Compare July 25, 2025 22:48
@nwangfw
Copy link
Collaborator

nwangfw commented Jul 25, 2025

lgtm

@Jeffwan Jeffwan merged commit 9f4db5f into vllm-project:main Jul 25, 2025
3 checks passed
@Jeffwan Jeffwan deleted the jiaxin/sglang-disaggregation-example branch July 25, 2025 22:53
ae86zhizhi pushed a commit to ae86zhizhi/aibrix that referenced this pull request Jul 30, 2025
* Add disaggregation SGLang examples

Signed-off-by: Jiaxin Shan <[email protected]>

* Change mooncake-transfer-engine to nixl and update image

Signed-off-by: Jiaxin Shan <[email protected]>

---------

Signed-off-by: Jiaxin Shan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants