Skip to content

Conversation

@Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Aug 7, 2025

Pull Request Description

feat: Add values.schema.json for Helm chart input validation

  • Add comprehensive JSON schema for validating chart values
  • Fix values.yaml data types to match schema requirements
  • Schema includes validation for:
    • Image specifications with repository, tag, and pull policies
    • Resource requirements with proper CPU/memory patterns
    • Probe configurations for health checks
    • Redis connection parameters

Related Issues

Resolves: #1413

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan Jeffwan changed the title feat: Add values.schema.json for Helm chart input validation [feat]: Add values.schema.json for Helm chart input validation Aug 7, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @Jeffwan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a robust JSON schema (values.schema.json) for the Helm chart's values.yaml files, enabling comprehensive input validation. Alongside this, it updates the existing stable.yaml, values.yaml, and vke.yaml files to ensure their data types and structures conform to the newly defined schema, thereby improving the reliability and maintainability of the Helm chart configuration.

Highlights

  • Helm Chart Validation: A new values.schema.json file has been added to provide a comprehensive JSON schema for validating Helm chart input values, covering image specifications, resource requirements, probe configurations, Redis connection parameters, and all component configurations.
  • Configuration Alignment: Existing values.yaml files (stable.yaml, values.yaml, vke.yaml) have been updated to align their data types (e.g., CPU values from integer to string, Redis tag from number to string) and key names (pullPolicy to imagePullPolicy) with the new schema's requirements.
  • Enhanced Reliability: The introduction of the schema and the subsequent data type fixes ensure that Helm linting passes with schema validation enabled, leading to more robust and error-resistant chart deployments.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a values.schema.json to improve Helm chart robustness. The schema is well-structured, and the updates to the values.yaml files are correct. I recommend enhancing the schema to improve its correctness and consistency, specifically around environment variable validation, container image definitions, and probe configurations.

@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Aug 8, 2025

We need to resolve the chart CI issue to unblock chart related changes. @omerap12 please also help review the PR

@Jeffwan Jeffwan mentioned this pull request Aug 8, 2025
- Add comprehensive JSON schema for validating chart values
- Fix values.yaml data types to match schema requirements

Signed-off-by: Jiaxin Shan <[email protected]>
@Jeffwan Jeffwan force-pushed the feature/helm-values-schema branch from d08e4f4 to 9117549 Compare August 8, 2025 18:11
Signed-off-by: Jiaxin Shan <[email protected]>
@Jeffwan Jeffwan force-pushed the feature/helm-values-schema branch from 9117549 to ada8ad5 Compare August 8, 2025 18:15
@Jeffwan Jeffwan merged commit 1008ec3 into vllm-project:main Aug 8, 2025
4 checks passed
@Jeffwan Jeffwan deleted the feature/helm-values-schema branch August 8, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC]: Production-Grade Helm Chart for AIBrix

1 participant