Fix missing traffic_pattern parameters in benchmark script

[happyandslow]

Pull Request Description

This PR fixes missing traffic_pattern parameters in benchmark script

Related Issues

Resolves: #1470

[gemini-code-assist]

Summary of Changes

Hello @happyandslow, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where critical traffic pattern parameters were not being correctly applied in the benchmark script. The primary change introduces a more robust and flexible configuration for synthetic workloads, allowing users to define traffic, prompt, and completion length patterns using either newly added preset options or existing file-based configurations. Additionally, a small improvement for API key handling has been included to prevent common configuration pitfalls.

Highlights

• Enhanced Synthetic Workload Configuration: The benchmark script's synthetic workload configuration has been significantly enhanced to offer more flexibility. Users can now choose between using predefined 'preset_patterns' for traffic, prompt length, and completion length, or continue to specify custom 'pattern_files'. This change is reflected in both the benchmark.py script's logic and the config.yaml structure.
• API Key Handling Improvement: A minor but important improvement has been added to the run_client method in benchmark.py. It now includes logic to check if the api_key is still set to its default placeholder value ('${API_KEY}'). If detected, a warning is logged, and the key is automatically set to "key" to prevent potential issues during execution.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the benchmark script to handle different traffic pattern configurations for synthetic workloads. My review focuses on improving code clarity, fixing a potential bug in API key handling, and correcting a minor typo in the configuration file. I've suggested a refactoring to reduce code duplication in benchmark.py, a fix for incorrect API key handling that could lead to authentication errors, and a correction for a double slash in a file path in config.yaml.