[Bug] fix count ready podset condition #1518
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @Epsilon314, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a bug in how 'ready' podsets are counted within the RoleSet controller. The change updates the calculateStatusFromPodSets function to use a more robust isPodSetReady helper function instead of a simple phase check. This ensures that the RoleSet status accurately reflects the true readiness of its associated podsets, improving the reliability of the controller's state reporting.
Highlights
- Refined PodSet Readiness Calculation: The logic for determining a 'ready' podset within the
calculateStatusFromPodSetsfunction has been updated. Previously, a podset was considered ready if its phase was notFailed. This has been refined to use a dedicatedisPodSetReadyhelper function, which presumably provides a more comprehensive check for readiness.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
@Jeffwan PTAL |
There was a problem hiding this comment.
Code Review
This pull request fixes a bug in how ready PodSets are counted by replacing a broad phase check with a call to a new isPodSetReady helper function. This is a good improvement. My review includes a comment about an inconsistency this change introduces: the new helper function is not used for all readiness checks in the same function, which could lead to maintainability issues and potential bugs. I've recommended making the readiness check consistent.
Epsilon314
changed the title
pkg/controller/roleset/sync.go
Outdated
| for _, podSet := range podSetList.Items { | ||
| totalReplicas++ | ||
| if podSet.DeletionTimestamp == nil && podSet.Status.Phase != orchestrationv1alpha1.PodSetPhaseFailed { | ||
| if podSet.DeletionTimestamp == nil && isPodSetReady(&podSet) { |
There was a problem hiding this comment.
Can you check if there are similar in podset elsewhere? 🤔
There was a problem hiding this comment.
move all other phase check to isPodSetReady and isPodSetActive, align with isPodReady/Active
Signed-off-by: zhuyiqing.wiz <[email protected]>
Epsilon314
force-pushed
the
yiqing/github/fix-podset-status
branch
from
0e130ae to
86ba907
Compare
3 participants
Pull Request Description
[Please provide a clear and concise description of your changes here]
Related Issues
Resolves: #[Insert issue number(s)]
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.