[Misc] Fix incorrect expressions for mean TTFT and TPOP in Grafana

[rudeigerc]

Pull Request Description

Fix incorrect expressions for mean TTFT and TPOP in Grafana, which have been defined in reverse.

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.

---

Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

• [Bug]: Corrections to existing functionality
• [CI]: Changes to build process or CI pipeline
• [Docs]: Updates or additions to documentation
• [API]: Modifications to aibrix's API or interface
• [CLI]: Changes or additions to the Command Line Interface
• [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

• PR title includes appropriate prefix(es)
• Changes are clearly explained in the PR description
• New and existing tests pass successfully
• Code adheres to project style and best practices
• Documentation updated to reflect changes (if applicable)
• Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

[gemini-code-assist]

Summary of Changes

Hello @rudeigerc, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a misconfiguration in the Grafana dashboard for the AIBrix vLLM Engine, specifically rectifying the formulas used to display mean Time To First Token (TTFT) and Time Per Output Token (TPOP). The change ensures that the dashboard accurately reflects these critical performance metrics by correcting the Prometheus query expressions.

Highlights

• Grafana Dashboard Correction: Corrected the Prometheus expressions for calculating "mean Time To First Token" (TTFT) and "mean Time Per Output Token" (TPOP) within the AIBrix vLLM Engine Grafana dashboard. These metrics were previously defined in reverse, leading to inaccurate visualizations.
• Metric Expression Swap: The expressions for TTFT and TPOP were swapped to ensure that the correct Prometheus metrics (vllm:time_to_first_token_seconds_sum and vllm:time_per_output_token_seconds_sum) are used for their respective calculations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a bug in the Grafana dashboard where the Prometheus expressions for mean 'Time to First Token' (TTFT) and 'Time per Output Token' (TPOP) were incorrect. The submitted changes correctly update the metric names in the queries, ensuring that the dashboard panels display the correct data. The fix is accurate and well-targeted. My review confirms the correctness of the changes, and I found no further issues within the modified code. As a minor note for future improvements, I observed a small inconsistency in the refId values for the 'Average' and 'Mean-{{pod}}' series between the TTFT and TPOP panels. This is cosmetic and doesn't affect functionality, but could be harmonized in a future change to improve the dashboard's maintainability. Since the relevant lines are outside the current diff, I haven't added a formal comment.

[Jeffwan]

/lgtm. Please share a screenshot next time and that's easier to accelerate the review process