[Misc] add kvcache wrapper

[nurali-techie]

Pull Request Description

Wrapper for KVCache added and used in KVCache integration test. Introduction of Wrapper would simplify tests and make it more maintainable.

Related Issues

Resolves: part of #1534 (kvcache)

Important: Before submitting, please complete the description above and review the checklist below.

---

Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

• [Bug]: Corrections to existing functionality
• [CI]: Changes to build process or CI pipeline
• [Docs]: Updates or additions to documentation
• [API]: Modifications to aibrix's API or interface
• [CLI]: Changes or additions to the Command Line Interface
• [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

• PR title includes appropriate prefix(es)
• Changes are clearly explained in the PR description
• New and existing tests pass successfully
• Code adheres to project style and best practices
• Documentation updated to reflect changes (if applicable)
• Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

[gemini-code-assist]

Summary of Changes

Hello @nurali-techie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new utility wrapper for KVCache objects, primarily aimed at streamlining the creation and manipulation of KVCache instances within integration tests. This change enhances the clarity and maintainability of test code by abstracting complex object initialization into a more readable, fluent API.

Highlights

• New KVCache Test Wrapper: Introduced a KVCacheWrapper in test/utils/wrapper/kvcache.go to provide a fluent API for constructing KVCache objects, simplifying test setup.
• Test Refactoring: Updated test/integration/webhook/kvcache_webhook_test.go to leverage the new KVCacheWrapper, significantly reducing boilerplate and improving the readability and maintainability of KVCache integration tests.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a KVCacheWrapper to simplify the creation of KVCache objects in integration tests, which is a great improvement for test maintainability. The implementation of the wrapper is good, but I have a few suggestions to make it more robust and complete. My main points are to ensure the wrapper is safe for reuse by returning copies of the object, and to extend it with methods for configuring the Spec to make the test code even more fluent. I've also shown how the test code can be simplified with these changes.

[nurali-techie]

@googs1025 so far this PR is not removing much boiler-plate code from integraion test.

Let me know if you want me to create KVCacheWrapper with default KVCache Spec. It will simplify lot of code in integration test.

func MakeKVCache(name string) *KVCacheWrapper {
	return &KVCacheWrapper{
		cache: orchestrationapi.KVCache{
			ObjectMeta: metav1.ObjectMeta{
				Name: name,
			},
			Spec: orchestrationapi.KVCacheSpec{
				Metadata: &orchestrationapi.MetadataSpec{},
				Service: orchestrationapi.ServiceSpec{
					Type: corev1.ServiceTypeClusterIP,
					Ports: []corev1.ServicePort{
						{
							Name:       "service",
							Port:       12345,
							TargetPort: intstr.FromInt(12345),
							Protocol:   corev1.ProtocolTCP,
						},
						{
							Name:       "admin",
							Port:       8088,
							TargetPort: intstr.FromInt(8088),
							Protocol:   corev1.ProtocolTCP,
						},
					},
				},
				Watcher: &orchestrationapi.RuntimeSpec{},
				Cache:   orchestrationapi.RuntimeSpec{},
			},
		},
	}
}

[googs1025]

@googs1025 so far this PR is not removing much boiler-plate code from integraion test.

Let me know if you want me to create KVCacheWrapper with default KVCache Spec. It will simplify lot of code in integration test.

func MakeKVCache(name string) *KVCacheWrapper {
	return &KVCacheWrapper{
		cache: orchestrationapi.KVCache{
			ObjectMeta: metav1.ObjectMeta{
				Name: name,
			},
			Spec: orchestrationapi.KVCacheSpec{
				Metadata: &orchestrationapi.MetadataSpec{},
				Service: orchestrationapi.ServiceSpec{
					Type: corev1.ServiceTypeClusterIP,
					Ports: []corev1.ServicePort{
						{
							Name:       "service",
							Port:       12345,
							TargetPort: intstr.FromInt(12345),
							Protocol:   corev1.ProtocolTCP,
						},
						{
							Name:       "admin",
							Port:       8088,
							TargetPort: intstr.FromInt(8088),
							Protocol:   corev1.ProtocolTCP,
						},
					},
				},
				Watcher: &orchestrationapi.RuntimeSpec{},
				Cache:   orchestrationapi.RuntimeSpec{},
			},
		},
	}
}

@nurali-techie If possible, please help to add it 😄 , because we will not only use it on the webhook side, but will also add it on the controller side in the future.

[nurali-techie]

@googs1025 Introduced WithDefaultConfiguration() which sets Spec with default value. Now this PR is ready for review 👍

[googs1025]

thanks for this help. All LGTM 😄