Skip to content

Conversation

@DwyaneShi
Copy link
Collaborator

Pull Request Description

  • KVCache API supports block hashes
  • Change parameter name tokens to query in all APIs to improve readability

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@DwyaneShi DwyaneShi requested a review from Jeffwan September 5, 2025 21:46
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @DwyaneShi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the KVCache API by introducing support for block hashes as cache keys, alongside the existing token list views. This allows for more flexible and potentially more efficient caching strategies, especially in scenarios where block-level identification is more natural. Additionally, a comprehensive refactoring has been undertaken to improve API readability by consistently renaming the tokens parameter to query across the entire KVCache codebase. A new utility function parse_kvcache_api_args was added to standardize argument parsing for KVCache operations, enabling overloaded method signatures for better usability.

Highlights

  • KVCache API Extension: The KVCache API now officially supports 'block hashes' as a new type of cache key, alongside the existing 'token list views'. This introduces BlockHashes and KVCacheKey types, allowing for more flexible caching strategies.
  • API Readability and Consistency: The parameter name tokens has been consistently renamed to query across all relevant KVCache APIs to improve readability and align with common terminology in data querying contexts.
  • Standardized Argument Parsing: A new utility function, parse_kvcache_api_args, has been introduced to centralize and standardize the parsing of various argument combinations for KVCache API calls, enabling more robust and user-friendly overloaded method signatures.
  • Core Logic Adaptation: Underlying cache management, L1/L2 cache operations, and memory region handling have been updated to seamlessly integrate and support both TokenListView and BlockHashes as valid key types, ensuring compatibility and correct behavior across the system.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for block hashes in the KVCache API, which is a significant feature enhancement. It also refactors the API by renaming the tokens parameter to query for improved readability and consistency. The use of @overload and a dedicated argument parsing function (parse_kvcache_api_args) is a good approach to handle the increased API flexibility.

My review focuses on a critical correctness issue in the BlockHashes equality and hashing logic, which could lead to incorrect cache behavior. I've also identified opportunities to improve code maintainability by simplifying a complex argument parsing function and ensuring naming consistency.

@DwyaneShi DwyaneShi force-pushed the haiyang/kvcache-hash-str branch from 0c02707 to 01dc74e Compare September 5, 2025 21:59
@DwyaneShi DwyaneShi force-pushed the haiyang/kvcache-hash-str branch from 01dc74e to a879c42 Compare September 9, 2025 19:02
@DwyaneShi
Copy link
Collaborator Author

@yapple has integrated into sglang with the newly introduced API in this PR and passed e2e UTs. merge it.

@DwyaneShi DwyaneShi merged commit ef4f3b2 into vllm-project:main Sep 9, 2025
11 checks passed
chethanuk pushed a commit to chethanuk/aibrix that referenced this pull request Sep 22, 2025
Signed-off-by: Haiyang Shi <[email protected]>
Co-authored-by: Haiyang Shi <[email protected]>
Signed-off-by: ChethanUK <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant