[Misc]: add more field for stormservice roleset podset

[googs1025]

Pull Request Description

[Please provide a clear and concise description of your changes here]

• add more field for stormservice roleset podset

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.

---

Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

• [Bug]: Corrections to existing functionality
• [CI]: Changes to build process or CI pipeline
• [Docs]: Updates or additions to documentation
• [API]: Modifications to aibrix's API or interface
• [CLI]: Changes or additions to the Command Line Interface
• [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

• PR title includes appropriate prefix(es)
• Changes are clearly explained in the PR description
• New and existing tests pass successfully
• Code adheres to project style and best practices
• Documentation updated to reflect changes (if applicable)
• Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

[gemini-code-assist]

Summary of Changes

Hello @googs1025, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves the observability and management of custom resources by exposing critical status fields directly in kubectl get output for PodSet, RoleSet, and StormService objects. It also refines the schema for upgradeOrder to ensure valid configurations.

Highlights

• Enhanced kubectl get output for Custom Resources: Added additionalPrinterColumns to the PodSet, RoleSet, and StormService Custom Resource Definitions (CRDs). This allows users to see key status information like ReadyPods, TotalPods, Phase, Age, Replicas, and Paused directly when running kubectl get for these resources.
• Schema validation update for upgradeOrder: Modified the schema for the upgradeOrder field within RoleSet and StormService definitions. The minimum allowed value is now 1 (previously 0), and the default value of 0 has been removed, enforcing a positive upgrade order.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds additionalPrinterColumns to the PodSet, RoleSet, and StormService custom resources. This will improve observability by displaying more information in the kubectl get output. The changes are correct and also include a fix for upgradeOrder validation in the CRD schemas. My feedback focuses on improving the naming convention of the new columns for better consistency with kubectl standards.

[googs1025]

➜  ~ kubectl apply -f aa.yaml
podset.orchestration.aibrix.ai/test-podset created
➜  ~ kubectl get podset
NAME          READYPODS   TOTALPODS   PHASE     AGE
test-podset   0           3           Pending   8s
➜  ~ kubectl get podset
NAME          READYPODS   TOTALPODS   PHASE   AGE
test-podset   3           3           Ready   11s

➜  ~ kubectl get roleset -w
NAME                      READY   AGE
vllm-1p1d-roleset-544gr   False   46s
vllm-1p1d-roleset-bmhrz   False   46s



vllm-1p1d-roleset-bmhrz   True    48s
vllm-1p1d-roleset-544gr   False   55s
vllm-1p1d-roleset-544gr   True    60s

➜  ~ kubectl get stormservice
NAME        REPLICAS   READY   PAUSED   AGE
vllm-1p1d   2                           29s
➜  ~ kubectl get stormservice
NAME        REPLICAS   READY   PAUSED   AGE
vllm-1p1d   2          True             69s

[Jeffwan]

seems all changes are around printColumn. looks good to me