[MISC] Refactor labels.go & add unit tests

[omerap12]

Pull Request Description

This change simplifies the function by replacing manual cloning with the more reliable DeepCopy method, reducing code and potential errors.

Related Issues

Resolves: NONE

Important: Before submitting, please complete the description above and review the checklist below.

---

Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

• [Bug]: Corrections to existing functionality
• [CI]: Changes to build process or CI pipeline
• [Docs]: Updates or additions to documentation
• [API]: Modifications to aibrix's API or interface
• [CLI]: Changes or additions to the Command Line Interface
• [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

• PR title includes appropriate prefix(es)
• Changes are clearly explained in the PR description
• New and existing tests pass successfully
• Code adheres to project style and best practices
• Documentation updated to reflect changes (if applicable)
• Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

[gemini-code-assist]

Summary of Changes

Hello @omerap12, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the reliability and test coverage of label utility functions. By switching to DeepCopy for label selector cloning, the code becomes more resilient to unintended side effects and easier to manage. The addition of thorough unit tests validates the behavior of these utility functions across various scenarios, improving overall code quality and stability.

Highlights

• Refactored Label Selector Cloning: The CloneSelectorAndAddLabel function in pkg/utils/labels.go has been refactored to utilize the DeepCopy method provided by metav1.LabelSelector. This change replaces the previous manual cloning logic, making the function more robust, less prone to errors, and simpler to maintain.
• Comprehensive Unit Tests Added: A new test file, pkg/utils/labels_test.go, has been introduced. This file includes extensive unit tests for CloneAndAddLabel, CloneAndRemoveLabel, AddLabel, and the refactored CloneSelectorAndAddLabel function, ensuring their correctness and proper deep-copy behavior.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a great improvement. The refactoring in labels.go to use DeepCopy simplifies the code and makes it more robust by removing the manual and bug-prone cloning logic. The addition of unit tests in labels_test.go is also a very positive step towards improving code quality and maintainability. I have a few suggestions for the new tests to make them more comprehensive and reliable by adding missing test cases and correcting the logic for verifying cloning behavior.

[googs1025]

This is different from the method name CloneSelectorAndAddLabel . If the label is empty, should a new one be cloned?

if labelKey == "" {
  return newSelector
}

[googs1025]

LGTM over all. only one nit

[googs1025]

This is different from the method name CloneSelectorAndAddLabel . If the label is empty, should a new one be cloned?

if labelKey == "" {
  return newSelector
}

This seems unnecessary, we can ignore this comment