[feat]Add tolerations values for chart

[my-git9]

Pull Request Description

[Please provide a clear and concise description of your changes here]

Add custom tolerations support to components

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.

---

Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

• [Bug]: Corrections to existing functionality
• [CI]: Changes to build process or CI pipeline
• [Docs]: Updates or additions to documentation
• [API]: Modifications to aibrix's API or interface
• [CLI]: Changes or additions to the Command Line Interface
• [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

• PR title includes appropriate prefix(es)
• Changes are clearly explained in the PR description
• New and existing tests pass successfully
• Code adheres to project style and best practices
• Documentation updated to reflect changes (if applicable)
• Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

[gemini-code-assist]

Summary of Changes

Hello @my-git9, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the flexibility of the aibrix Helm chart by enabling users to configure Kubernetes tolerations for key application components. This allows pods to be scheduled on nodes that have specific taints, which is crucial for managing diverse node pools and specialized hardware within a Kubernetes cluster. The changes involve updating the values.yaml with new toleration fields and modifying the component manifests to dynamically apply these settings.

Highlights

• Tolerations Support: Introduced the ability to define custom Kubernetes tolerations for several core components within the Helm chart, including the controller manager, gateway plugin, GPU optimizer, gateway Envoy proxy, and metadata service.
• Helm Chart Configuration: Added new tolerations: [] fields to the values.yaml file for each of the affected components, providing default empty arrays to allow for optional configuration.
• Dynamic Manifest Generation: Implemented Helm template logic in the respective deployment and gateway manifests to conditionally apply the specified tolerations if they are defined in the values.yaml.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully adds support for custom tolerations to various components in the Helm chart. The implementation is correct, using with blocks to conditionally include the tolerations and toYaml to render them. I've added a few minor suggestions to improve code style and consistency, such as ensuring all YAML files end with a newline and maintaining consistent spacing in values.yaml. Overall, great work on adding this useful feature.

[my-git9]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces support for tolerations across multiple components within the Helm chart, which is a valuable addition for flexible scheduling. The changes are consistently applied to the values files and deployment templates. My main feedback is to improve the Helm templating logic to correctly handle empty tolerations lists, which is a key use case for overriding settings from parent charts. I've left specific suggestions on each of the affected template files. Additionally, please remember to fill out the pull request description to provide context for reviewers.

[Jeffwan]

looks good to me. if tolerations: [] there's no need to render this out. We do not explicitly render tolerations: [] in final yaml