Skip to content

Conversation

@TylerGillson
Copy link
Contributor

@TylerGillson TylerGillson commented Sep 30, 2025

Pull Request Description

Deduplicates labels in the Helm chart templates that are currently preventing the flux helm-controller from successfully installing the aibrix chart.

You can verify the duplication by issuing helm template aibrix dist/chart -f dist/chart/values.yaml --namespace aibrix-system --debug > verify.yaml and inspecting the relevant sections of verify.yaml.

Before

# Source: aibrix/templates/metadata-service/redis.yaml
...
spec:
  template:
    metadata:
      labels:
        app.kubernetes.io/version: "0.4.1"
        helm.sh/chart: "0.4.1"
        app.kubernetes.io/name: aibrix
        app.kubernetes.io/instance: aibrix
        app.kubernetes.io/managed-by: Helm
        app.kubernetes.io/name: aibrix <-- dupe
        app.kubernetes.io/instance: aibrix <-- dupe
        app.kubernetes.io/component: aibrix-metadata-redis

# Source: aibrix/templates/gateway-instance/gateway.yaml
...
        patch:
          type: StrategicMerge
          value:
            spec:
              template:
                metadata:
                  labels:
                    app.kubernetes.io/name: aibrix <-- dupe
                    app.kubernetes.io/instance: aibrix <-- not a dupe, but questionable
                    app.kubernetes.io/name: envoy
                    app.kubernetes.io/component: proxy

After

# Source: aibrix/templates/metadata-service/redis.yaml
...
spec:
  template:
    metadata:
      labels:
        app.kubernetes.io/version: "0.4.1"
        helm.sh/chart: "0.4.1"
        app.kubernetes.io/name: aibrix
        app.kubernetes.io/instance: aibrix
        app.kubernetes.io/managed-by: Helm
        app.kubernetes.io/component: aibrix-metadata-redis

# Source: aibrix/templates/gateway-instance/gateway.yaml
...
        patch:
          type: StrategicMerge
          value:
            spec:
              template:
                metadata:
                  labels:
                    app.kubernetes.io/name: envoy
                    app.kubernetes.io/component: proxy

Flux Error

Flux fails for the same underlying reason as described in fluxcd/helm-controller#283. The exact error for this particular chart is as follows:

message: |-                                                                                                                                                         
       Helm install failed for release aibrix-system/aibrix with chart [email protected]: error while running post render on files: map[string]interface {}(nil): yaml: unmarshal errors:                                                                                                                                                            
         line 32: mapping key "app.kubernetes.io/name" already defined at line 29                                                                                        
         line 33: mapping key "app.kubernetes.io/instance" already defined at line 30

Related Issues

N/A

Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@TylerGillson TylerGillson marked this pull request as ready for review September 30, 2025 18:00
@TylerGillson TylerGillson changed the title Bug: dedupe labels causing flux helm-controller to choke Bug: remove duplicate labels that prevent flux helm-controller from deploying the aibrix chart Sep 30, 2025
@Jeffwan Jeffwan force-pushed the fix/duplicate-labels branch from 3d84565 to cb4bce2 Compare October 1, 2025 17:20
Copy link
Collaborator

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution

@Jeffwan Jeffwan merged commit 6ede0b2 into vllm-project:main Oct 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants