[CLI] Fix replicate args assignment in main.go

[ChenTaoyu-SJTU]

Pull Request Description

There are two replicate assignment of the flag to enableLeaderElection in aibrix/cmd/controllers/main.go. I remove the former for the code clarity.

This change will make the user interface different, since the --leader-elect flag is not used any more and we could only use --enable-leader-election flag in the future.

Related Issues

Resolves: No Issues, This is a little fix for code clarity.

Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

• [Bug]: Corrections to existing functionality
• [CI]: Changes to build process or CI pipeline
• [Docs]: Updates or additions to documentation
• [API]: Modifications to aibrix's API or interface
• [CLI]: Changes or additions to the Command Line Interface
• [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

• PR title includes appropriate prefix(es)
• Changes are clearly explained in the PR description
• New and existing tests pass successfully
• Code adheres to project style and best practices
• Documentation updated to reflect changes (if applicable)
• Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

[gemini-code-assist]

Summary of Changes

Hello @ChenTaoyu-SJTU, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing code clarity and consistency within the command-line interface by eliminating a duplicate flag definition. The change streamlines the configuration for leader election, ensuring that only one designated flag, --enable-leader-election, is used going forward, thereby simplifying user interaction and maintaining a cleaner codebase.

Highlights

• Code Clarity: Removed a redundant assignment of the enableLeaderElection flag in cmd/controllers/main.go to improve code clarity.
• CLI Flag Standardization: Standardized the command-line interface for leader election, deprecating the --leader-elect flag. Users should now exclusively use the --enable-leader-election flag.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly removes a redundant --leader-elect flag to improve code clarity. While this is a positive change, it introduces a breaking change for the CLI. I've identified a critical issue where the Helm chart for deployment has not been updated to reflect this change, which will cause deployment failures. Please see the specific comment for details on how to resolve this.

[Jeffwan]

@ChenTaoyu-SJTU thanks for the update. it is a problem. I notice some yaml deployments actually still use --leader-elect (you can search reference in yaml), that's the reason integration test failed.

could you either update the references or remove --enable-leader-election but keep --leader-elect (kubebuilder way)

[ChenTaoyu-SJTU]

@Jeffwan sure, I will remove --enable-leader-election but keep --leader-elect.

[googs1025]

LGTM