-
Notifications
You must be signed in to change notification settings - Fork 501
Make Gateway API compatible with OpenAI API #1679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Gateway API compatible with OpenAI API #1679
Conversation
Summary of ChangesHello @Jeffwan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Gateway API's error handling by making its error responses fully compatible with the OpenAI API specification. The changes involve introducing a structured approach to error generation, including new constants for error types and codes, and modifying existing functions to consistently produce detailed JSON error payloads that include 'type', 'code', and 'param' fields. This ensures better interoperability and a more predictable error experience for clients interacting with the gateway. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request makes important changes to align the gateway's error responses with the OpenAI API format, which is a great improvement for client compatibility. The approach of centralizing error generation logic in util.go is solid.
My review focuses on ensuring the new error format is fully compliant with OpenAI's standards. I've found a few areas where the error types and codes could be more accurate. I've also noted a minor issue with error handling in the JSON serialization logic. The suggested changes should help make the error handling more robust and fully compliant.
bac7ebd to
acf06c1
Compare
Signed-off-by: Jiaxin Shan <[email protected]>
acf06c1 to
799343a
Compare
|
this one has enough test coverage, I will merge it directly to unblock coming PRs. |
Pull Request Description
I notice the error response format is completely incompatible. after checking https://github.com/openai/openai-openapi/tree/master?tab=readme-ov-file
Related Issues
Resolves: #1677, part of #846
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.