[Misc] Optimize runtime sidecar injection logic

[Jeffwan]

Pull Request Description

[Please provide a clear and concise description of your changes here]

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.

---

Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

• [Bug]: Corrections to existing functionality
• [CI]: Changes to build process or CI pipeline
• [Docs]: Updates or additions to documentation
• [API]: Modifications to aibrix's API or interface
• [CLI]: Changes or additions to the Command Line Interface
• [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

• PR title includes appropriate prefix(es)
• Changes are clearly explained in the PR description
• New and existing tests pass successfully
• Code adheres to project style and best practices
• Documentation updated to reflect changes (if applicable)
• Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

[gemini-code-assist]

Summary of Changes

Hello @Jeffwan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the runtime sidecar injection mechanism by centralizing common utility functions into a new shared package. This change significantly reduces code duplication across different webhook implementations, making the codebase more modular and easier to maintain. Additionally, it enhances the clarity of the sidecar detection logic within the model adapter controller.

Highlights

• Code Centralization: Extracted common utility functions for runtime sidecar injection, such as building the sidecar container, inferring engine types, and checking for existing containers, into a new, dedicated file pkg/webhook/sidecar_injection.go.
• Reduced Duplication: Eliminated redundant code in pkg/webhook/deployment_webhook.go and pkg/webhook/stormservice_webhook.go by leveraging the newly centralized shared functions, improving maintainability.
• Improved Clarity: Updated comments in pkg/controller/modeladapter/modeladapter_controller.go to provide clearer explanations of the logic for determining when to use the runtime sidecar API during model load and unload operations.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a good refactoring that optimizes the runtime sidecar injection logic. It centralizes the duplicated code for building the sidecar container and related utilities into a new pkg/webhook/sidecar_injection.go file. This significantly cleans up deployment_webhook.go and stormservice_webhook.go. The changes in modeladapter_controller.go are minor comment updates that improve clarity.

My main feedback is on the new sidecar_injection.go file, where the Scheme for HTTP probes should be explicitly set for better readability and future-proofing, even though it has a default value. Overall, this is a solid improvement to the codebase.

[Jeffwan]

@googs1025 I clean up some duplicate codes, PTAL

[googs1025]

LGTM