Skip to content

Conversation

@Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Oct 20, 2025

Pull Request Description

Add VKE doc

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Jeffwan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on enhancing documentation related to Kubernetes deployments, specifically introducing VKE (Virtual Kubelet Engine) documentation and refining existing Kubernetes examples. It also updates a key SGLang disaggregation example to reflect newer model versions and a more robust pod grouping and indexing strategy, improving the clarity and relevance of the provided deployment configurations.

Highlights

  • VKE Documentation: New documentation for VKE (Virtual Kubelet Engine) is introduced, and existing Kubernetes examples are updated to align with VKE usage, enhancing clarity for advanced deployments.
  • Kubernetes Example Updates: The tp-1p1d.yaml example for SGLang disaggregation has been updated to use pod-group-index for selectors and node ranking, and the example model was upgraded from Qwen2.5-7B to Qwen3-8B.
  • Installation Guide Refinement: Outdated custom configuration instructions have been removed from the stable version installation guide, streamlining the installation process.
  • Pod Grouping Logic: The tp-1p1d.yaml now uses replicas: 1 with podGroupSize: 2 for prefill and decode roles, indicating a refined approach to how pods are grouped and managed within the Kubernetes cluster.
  • Environment Variable Addition: The UCX_TLS environment variable with value ^gga has been added to the prefill and decode containers in the Kubernetes example, potentially for network optimization.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for VKE and updates related examples. The documentation changes involve moving the advanced Kubernetes examples and adding a new VKE-specific document link. The example YAML for disaggregated inference is updated to use a newer model and adapt to recent API changes in aibrix, such as the introduction of pod groups. My review focuses on a potentially critical misconfiguration in the updated example.

@Jeffwan Jeffwan force-pushed the jiaxin/volcano-engine-docs branch from 6db160f to a1a8488 Compare October 20, 2025 07:41
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented Oct 20, 2025

/cc @googs1025

Copy link
Collaborator

@googs1025 googs1025 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jeffwan Jeffwan merged commit 4456c85 into vllm-project:main Oct 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants