[Misc] Added unit tests for WorkloadScale.SetDesiredReplicas #1692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@googs1025 this PR is ready for review. I have added all postive unit tests for |
Contributor
Author
|
@googs1025 I think we are sort of good with code coverage for WorkloadScale with this PR. Three methods are covered. Only Validate() is remaining, but I don't see it's getting used in code. Let me know if you want me to add tests for it 👍 
|
nurali-techie
force-pushed
the
nur/patch-workload-scale-test
branch
from
2f735b2 to
28723ca
Compare
Collaborator
|
will review in these day |
Signed-off-by: Nurali Techie <[email protected]>
Signed-off-by: Nurali Techie <[email protected]>
nurali-techie
force-pushed
the
nur/patch-workload-scale-test
branch
from
28723ca to
14d913e
Compare
googs1025
approved these changes
Oct 24, 2025
Contributor
Author
|
Thanks @googs1025 for review. Let me know if you see any value in adding test for |
xvoron
pushed a commit
to xvoron/aibrix
that referenced
this pull request
Oct 29, 2025
…oject#1692) * test: added test for SetDesiredReplicas Signed-off-by: Nurali Techie <[email protected]> * chore: fix lint issue Signed-off-by: Nurali Techie <[email protected]> --------- Signed-off-by: Nurali Techie <[email protected]> Signed-off-by: Artyom Voronin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
To improve coverage for podautoscaler, added unit tests for WorkloadScale.SetDesiredReplicas().
Related Issues
Resolves: part of [#1649] (
SetDesiredReplicas()unit tests)Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.