[batch] Add jsonl input and file validation

[Jeffwan]

Pull Request Description

• Added _validate_batch_input_file() function with comprehensive validation
• Validates JSONL format (each line is valid JSON)
• Checks required fields: custom_id, method, url, body
• Enforces 50,000 request limit per batch
• File size limits (100 MB configurable)

Related Issues

Resolves: part of #1644

Important: Before submitting, please complete the description above and review the checklist below.

---

Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

• [Bug]: Corrections to existing functionality
• [CI]: Changes to build process or CI pipeline
• [Docs]: Updates or additions to documentation
• [API]: Modifications to aibrix's API or interface
• [CLI]: Changes or additions to the Command Line Interface
• [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

• PR title includes appropriate prefix(es)
• Changes are clearly explained in the PR description
• New and existing tests pass successfully
• Code adheres to project style and best practices
• Documentation updated to reflect changes (if applicable)
• Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

[gemini-code-assist]

Summary of Changes

Hello @Jeffwan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the robustness of the batch processing system by introducing comprehensive validation for input files. It ensures that batch files adhere to the JSONL format, contain all necessary request details, and respect predefined limits on the number of requests, thereby improving data integrity and preventing malformed or oversized batch submissions.

Highlights

• New Batch Input Validation Function: Introduced _validate_batch_input_file() to perform comprehensive validation on batch input files.
• JSONL Format and Content Validation: The new function validates that each line in the input file is a valid JSON object and checks for the presence of required fields: custom_id, method, url, and body.
• Request Limit Enforcement: Batch input files are now limited to a maximum of 50,000 requests to prevent excessively large batches.
• HTTP Method Validation: Ensures that the method field in each batch request contains a valid HTTP method (GET, POST, PUT, DELETE, PATCH).
• File Size Constants: Defined constants MAX_FILE_SIZE_MB and MAX_FILE_SIZE_BYTES in files.py for potential future use in file size validation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces validation for batch input files, which is a great addition for data integrity. The new _validate_batch_input_file function is comprehensive. However, I've identified a critical bug in how requests are counted, which could lead to incorrect behavior when checking against the maximum request limit. There's also a significant performance concern regarding memory usage, as the entire file is read into memory. I've provided a suggestion to address both issues by using a streaming approach. Additionally, there are several smaller suggestions to improve code quality, such as moving constants out of loops, removing unused code, and adding type hints.