Skip to content

Conversation

@Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Oct 26, 2025

Consolidate python images into one

Pull Request Description

  1. Image size reduced by from 900MiB → 300MB. Separated profiling dependencies into optional group in
    python/aibrix/pyproject.toml
  2. Unified Docker image from Dockerfile.python to consolidate all python images like runtime and metadata
  3. Makefile and CI files updated to use the latest Dockerfile

just notice we remove the entrypoint in the dockerfile for share purpose. Instead, we need to have command in all kubernetes manifests in future.

  # Runtime
  docker run aibrix/runtime:latest

  # Metadata
  docker run aibrix/runtime:latest aibrix_metadata --host 0.0.0.0

  # Batch Worker
  docker run aibrix/runtime:latest aibrix_batch_worker --load-job-from-api

  # Downloader
  docker run aibrix/runtime:latest aibrix_download --model llama-3-8b

Related Issues

Resolves: #1699

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Jeffwan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly optimizes the CI/CD process by reducing the footprint of Python runtime container images. It achieves this by consolidating multiple Python Dockerfiles into a single, efficient Dockerfile.python and by segregating large profiling-related dependencies into an optional group. This change not only slashes image sizes by two-thirds but also streamlines the build process and improves deployment efficiency for core services.

Highlights

  • Reduced Container Image Size: The runtime container image size has been drastically cut from 900MiB to 300MB, a two-thirds reduction.
  • Consolidated Python Images: All Python-based services (runtime, metadata, etc.) are now built from a single, unified Dockerfile.python, streamlining the build process.
  • Optional Profiling Dependencies: Profiling and benchmarking tools' dependencies have been moved to an optional group in pyproject.toml, preventing their inclusion in standard runtime images and contributing to size reduction.
Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/docker-push-images.yml
    • .github/workflows/release-build.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively reduces the runtime container image size by consolidating multiple Python Dockerfiles into a single one and separating profiling dependencies into an optional group. The changes are well-executed and significantly improve image size and maintainability. I have one minor suggestion to improve a comment's clarity in pyproject.toml.

Consolidate python images into one

Signed-off-by: Jiaxin Shan <[email protected]>
@Jeffwan Jeffwan force-pushed the jiaxin/python-slim-image branch from 65a2f0e to 4f2a0e3 Compare October 26, 2025 07:18
@Jeffwan Jeffwan merged commit ded6b36 into vllm-project:main Oct 26, 2025
18 checks passed
@Jeffwan Jeffwan deleted the jiaxin/python-slim-image branch October 26, 2025 08:00
xvoron pushed a commit to xvoron/aibrix that referenced this pull request Oct 29, 2025
Consolidate python images into one

Signed-off-by: Jiaxin Shan <[email protected]>
Signed-off-by: Artyom Voronin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

clean up: consolidate runtime and metadata dockerfile

1 participant