-
Notifications
You must be signed in to change notification settings - Fork 501
[CI] Reduce runtime container image size #1702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Jeffwan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly optimizes the CI/CD process by reducing the footprint of Python runtime container images. It achieves this by consolidating multiple Python Dockerfiles into a single, efficient Dockerfile.python and by segregating large profiling-related dependencies into an optional group. This change not only slashes image sizes by two-thirds but also streamlines the build process and improves deployment efficiency for core services. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively reduces the runtime container image size by consolidating multiple Python Dockerfiles into a single one and separating profiling dependencies into an optional group. The changes are well-executed and significantly improve image size and maintainability. I have one minor suggestion to improve a comment's clarity in pyproject.toml.
Consolidate python images into one Signed-off-by: Jiaxin Shan <[email protected]>
65a2f0e to
4f2a0e3
Compare
Consolidate python images into one Signed-off-by: Jiaxin Shan <[email protected]> Signed-off-by: Artyom Voronin <[email protected]>
Consolidate python images into one
Pull Request Description
python/aibrix/pyproject.toml
just notice we remove the entrypoint in the dockerfile for share purpose. Instead, we need to have command in all kubernetes manifests in future.
Related Issues
Resolves: #1699
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.