-
Notifications
You must be signed in to change notification settings - Fork 500
[Docs] Add volcano engine startup docs and quick start #1725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Add volcano engine startup docs and quick start #1725
Conversation
Summary of ChangesHello @Jeffwan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the AIBrix deployment experience on Volcano Engine Kubernetes Engine (VKE) by introducing comprehensive installation documentation and ready-to-use quick start YAML files. These additions aim to streamline the process for users to set up and run AIBrix, including both standard and disaggregated models, within a VKE environment, facilitating quicker adoption and testing. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds documentation and quick start configurations for deploying AIBrix on Volcano Engine. The changes include updating container image repositories and tags to public release versions, and adding new documentation and sample YAML files. My review focuses on improving the correctness and security of the new documentation and sample files. I've identified a critical syntax error in a sample curl command that would cause it to fail. I've also pointed out a missing prerequisite step in the documentation that would prevent the sample application from deploying correctly. Additionally, I've raised concerns about the use of hostPath with a privileged directory in the sample YAMLs, which is a security risk, and suggested improvements for robustness in a script that retrieves a service IP. Finally, a minor suggestion is made to follow best practices in YAML formatting for version tags.
fd9062f to
4a7b044
Compare
|
@Jeffwan interesting addition 👍 Can you plz share motivation/reason for adding volcano engine support, Thanks :-) |
This is a deployment example provided internally by bytendance. |
|
Thanks @googs1025 for info. So I think that this doc will help folks at bytedance to install aibrix on their volcano engine 👍 |
4a7b044 to
bd7ffde
Compare
|
yes. We use volcano engine for testing. that's the purpose |
Signed-off-by: Jiaxin Shan <[email protected]>
bd7ffde to
1fe8e28
Compare
Pull Request Description
Related Issues
Resolves: #[Insert issue number(s)]
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.