Add users CRUD API #181
Merged
Add users CRUD API #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeffwan
reviewed
Sep 17, 2024
Collaborator
|
Seems the python testing script is flaky? This PR doesn't change any python code. @brosoul |
Jeffwan
reviewed
Sep 17, 2024
Collaborator
|
Beside the container image, rest part looks good to me. feel free to merge it after dockerfile is updated. |
Jeffwan
approved these changes
Sep 18, 2024
Collaborator
@Jeffwan This looks like the pypi source is unstable, causing the fail of installing poetry. From the logs, it appears that the corresponding meta information for I don't have any good workaround at the moment, just retry it 😂 |
gangmuk
pushed a commit
that referenced
this pull request
Jan 25, 2025
* Add users CRUD API * nit * read userconfig in gateway plugin * nit * address code review comments * revert dockerfile changes --------- Co-authored-by: varungupta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.